From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21713C07E95 for ; Wed, 7 Jul 2021 19:28:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A943761CC2 for ; Wed, 7 Jul 2021 19:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A943761CC2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 65BE56B0011; Wed, 7 Jul 2021 15:28:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60BFD6B005D; Wed, 7 Jul 2021 15:28:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ACF66B006C; Wed, 7 Jul 2021 15:28:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 244396B0011 for ; Wed, 7 Jul 2021 15:28:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7418A22ACE for ; Wed, 7 Jul 2021 19:28:51 +0000 (UTC) X-FDA: 78336779262.10.B0644DA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 627809000247 for ; Wed, 7 Jul 2021 19:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BhBZWEYcFlxuVvSAsmS5gv8zy8o+jsEbcEExhMSd3eo=; b=BrPBSSUj/JX65304k1+dRXGvWR dZhuNplsCU/8NOxj2QAX23zHkqjvzASJDGZg9JyRcV6Cggsd2/MeFuRbiL0eRTUP4PhIj9Mr7yIM5 TBGA+az2hYFZMGC393mxnuIdzaH1Y7Okd1BcyLFr80krULTUd+KyPgCX6mZixz0u5Sr1oDXSTcpFd +/Kh0a8SgbvSh9BrcomsmviViFOmBCj4Fp8PFpXZ7VJ6ebhTa/NbNygM/CrC0DOnNubdwA067oYGJ y3tpw/EJXLXdKKnIPurDGyowfgMbQv0JNYXzfA1yly44GzPsN3wC6QW18Vc1jrps8hW25w2SsSFbr Uf7efN7w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1DDr-00Ck4p-C0; Wed, 07 Jul 2021 19:28:42 +0000 Date: Wed, 7 Jul 2021 20:28:39 +0100 From: Matthew Wilcox To: Johannes Weiner Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, Michal Hocko , Vladimir Davydov Subject: Re: [PATCH v3 13/18] mm/memcg: Add folio_memcg_lock() and folio_memcg_unlock() Message-ID: References: <20210630040034.1155892-1-willy@infradead.org> <20210630040034.1155892-14-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BrPBSSUj; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 627809000247 X-Rspam-User: nil X-Stat-Signature: 7giguiibtsnc1jd1snxq619m5memi3xk X-HE-Tag: 1625686130-393205 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 07, 2021 at 01:08:51PM -0400, Johannes Weiner wrote: > On Wed, Jun 30, 2021 at 05:00:29AM +0100, Matthew Wilcox (Oracle) wrote: > > -static void __unlock_page_memcg(struct mem_cgroup *memcg) > > +static void __memcg_unlock(struct mem_cgroup *memcg) > > This is too generic a name. There are several locks in the memcg, and > this one only locks the page->memcg bindings in the group. Fair. __memcg_move_unlock looks like the right name to me?