From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: qiang.zhang@windriver.com, mgorman@techsingularity.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: avoid hard lockups in __alloc_pages_bulk()
Date: Sat, 10 Jul 2021 22:10:03 +0100 [thread overview]
Message-ID: <YOoMq0Bl6M/LV6mJ@casper.infradead.org> (raw)
In-Reply-To: <20210710114613.0db3ac139a7b3102a6ca3ad4@linux-foundation.org>
On Sat, Jul 10, 2021 at 11:46:13AM -0700, Andrew Morton wrote:
> On Sat, 10 Jul 2021 19:29:29 +0800 qiang.zhang@windriver.com wrote:
>
> > From: Zqiang <qiang.zhang@windriver.com>
> >
> > The __alloc_pages_bulk() mainly used for batch allocation of
> > order-0 pages, in the case of holding pagesets.lock, if too
> > many pages are required, maybe trigger hard lockup watchdog.
>
> Ouch. Has this been observed in testing? If so, can you please share
> the kernel debug output from that event?
This should be fixed in the caller by asking for fewer pages.
The NFS and vmalloc cases have already been fixed for this.
next prev parent reply other threads:[~2021-07-10 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 11:29 [PATCH] mm/page_alloc: avoid hard lockups in __alloc_pages_bulk() qiang.zhang
2021-07-10 18:46 ` Andrew Morton
2021-07-10 21:10 ` Matthew Wilcox [this message]
2021-07-10 22:57 ` Zhang, Qiang
2021-07-15 8:35 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOoMq0Bl6M/LV6mJ@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=qiang.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).