From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52EACC07E9C for ; Mon, 12 Jul 2021 18:31:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D965E61283 for ; Mon, 12 Jul 2021 18:31:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D965E61283 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBDCE6B0092; Mon, 12 Jul 2021 14:31:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6DF56B0095; Mon, 12 Jul 2021 14:31:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0E8B6B0096; Mon, 12 Jul 2021 14:31:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 802476B0092 for ; Mon, 12 Jul 2021 14:31:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 896B718506A21 for ; Mon, 12 Jul 2021 18:31:32 +0000 (UTC) X-FDA: 78354778824.12.B283620 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf18.hostedemail.com (Postfix) with ESMTP id B7B7B4002087 for ; Mon, 12 Jul 2021 18:31:31 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id h18so9021686qve.1 for ; Mon, 12 Jul 2021 11:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=91QVBsn60C5sxxxstdN+oyAoFM1Vz8Xrhf5wNCClAZ0=; b=a019hXVML1QTTEfMxq4xOcak1XJogepYRETIyj3+hyPTloWky9q429jsqUoXR7NVUp x0sleTMvkwrpFBp5Iq492/WoP65dbpZlQV0HMy3pWuYArruuTgwsz2kNgmgvcfB0Uf8A zDuf0ZV/XAINwDV7rOhVLr2StoZ41vBZMq4y+WzvgRTKLKILuFcPWYjse+WchS9SplIV aQi/Q0AzrsPNr6udTmAyz7xaxLOL4RHnMtQohfkumhs2UOheE+1WjeKcsex9RZix8MRU IVEcs/d+bN2CTr2OCyJfFWTq0bnSxNX0smTokjuWD78ZfZS/wzfyHrDGXqBkR8ux7Lx7 4MOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=91QVBsn60C5sxxxstdN+oyAoFM1Vz8Xrhf5wNCClAZ0=; b=iYXlpoowCP2MHECZx40tWl4wZM4JpDJcCZ+Yr6lS3DmDyfSrqxUVkHAW47wsziuczw uMybLZ/u+LivpLZsp+Y1HJMeEh3xsySVHgKkjpYWmQhn5eTgNWgn5GMFIWgkg9z7UTva l7+LKIXjAjwpSfruF4L2ikM0EjOX+BpUn/YjXxy7coGvoKOOs4cfThSilMoWOKzbjycl H8LafPFL2Tl3jOEwCbSdrjLKaPuZmyPqD0ngmGngdk4IlRA4KCV6FR/lnGiYXJuq4S8M Cs54Vxf1d4undAsBNr4qEO6LD+zPQRXrq27HBQbjTgltm9Bia5mL8fbNtTw0u9YL23tE qtxA== X-Gm-Message-State: AOAM533HowF95XcFmn3GvRNQ3iF+Oc3xpJqSRfuASg7lyc5r8iOlSBQU k46tlVoN4jzFG1vvhQ+vY0YgAA== X-Google-Smtp-Source: ABdhPJy1mAKtVsdu1BKkSpdIw3PhdMIO5F6wAuKWr6F1MoPxiv4FZkGIUcRiLa3CFNZlpp0QbqBqcQ== X-Received: by 2002:a05:6214:224c:: with SMTP id c12mr431607qvc.7.1626114689982; Mon, 12 Jul 2021 11:31:29 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:a40c]) by smtp.gmail.com with ESMTPSA id 71sm5935964qtc.97.2021.07.12.11.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 11:31:28 -0700 (PDT) Date: Mon, 12 Jul 2021 14:31:27 -0400 From: Johannes Weiner To: Suren Baghdasaryan Cc: tj@kernel.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, songmuchun@bytedance.com, shy828301@gmail.com, alexs@kernel.org, richard.weiyang@gmail.com, vbabka@suse.cz, axboe@kernel.dk, iamjoonsoo.kim@lge.com, david@redhat.com, willy@infradead.org, apopple@nvidia.com, minchan@kernel.org, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com Subject: Re: [PATCH v2 1/1] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Message-ID: References: <20210709171554.3494654-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210709171554.3494654-1-surenb@google.com> Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=a019hXVM; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.50 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam02 X-Stat-Signature: zsnfox15kpki1ziy93t4kio3oae3nu18 X-Rspamd-Queue-Id: B7B7B4002087 X-HE-Tag: 1626114691-88917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 09, 2021 at 10:15:54AM -0700, Suren Baghdasaryan wrote: > Inline mem_cgroup_{charge/uncharge} and mem_cgroup_uncharge_list functions > functions to perform mem_cgroup_disabled static key check inline before > calling the main body of the function. This minimizes the memcg overhead > in the pagefault and exit_mmap paths when memcgs are disabled using > cgroup_disable=memory command-line option. > This change results in ~0.4% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configurationon on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan Acked-by: Johannes Weiner Thanks!