From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A42C636C8 for ; Fri, 16 Jul 2021 02:50:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54AA2613D9 for ; Fri, 16 Jul 2021 02:50:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54AA2613D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 789D18D00F4; Thu, 15 Jul 2021 22:50:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 739F28D00EC; Thu, 15 Jul 2021 22:50:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 602228D00F4; Thu, 15 Jul 2021 22:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 3CDEC8D00EC for ; Thu, 15 Jul 2021 22:50:25 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0047F1839A9F3 for ; Fri, 16 Jul 2021 02:50:23 +0000 (UTC) X-FDA: 78366922368.16.9CEDA04 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 176231004E6B for ; Fri, 16 Jul 2021 02:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gMlvBLObPJT3YmRhs9iQMwy3E2OqoakIoEKCEfOZcX0=; b=vgvSRBZIZXuXoEKicIy49w4iCn wSG58yq2P84KKKFtFY0/rJBrDjJXEJ/r1wBz0F75bdK/ezr9mVRkz5jXDQafYO44tdPl7F5TPcfMa avJEDz5F+SP1qVC4yDW7y79z5eDfliLvSRLuna82d9T75Gej7INWQO7oOsi9lstGyp0ZHtvTUxpAO iI67mJaorxloEa4843ZDLCAFsXc2Jjufz7HhWOdkdLGt+xDLR7g22+YnaZi3Kxjmz7KdkYKTxHqim 4FnfHuKt5zD7+6N6pOFZk/54EZs99VuenWAuh4/uqCzzzijpz9hH31GIw8Q9syQZkQ0PTQgupw+6M MZ/J3tLA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4Dut-00455o-4q; Fri, 16 Jul 2021 02:49:38 +0000 Date: Fri, 16 Jul 2021 03:49:31 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 128/138] iomap: Support multi-page folios in invalidatepage Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-129-willy@infradead.org> <20210715221018.GT22357@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715221018.GT22357@magnolia> Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vgvSRBZI; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: e3t1fwf5dop63iubzajxh34qjbykqnky X-Rspamd-Queue-Id: 176231004E6B X-Rspamd-Server: rspam01 X-HE-Tag: 1626403822-835960 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 03:10:18PM -0700, Darrick J. Wong wrote: > On Thu, Jul 15, 2021 at 04:36:54AM +0100, Matthew Wilcox (Oracle) wrote: > > If we're punching a hole in a multi-page folio, we need to remove the > > per-page iomap data as the folio is about to be split and each page will > > need its own. This means that writepage can now come across a page with > > no iop allocated, so remove the assertion that there is already one, > > and just create one (with the uptodate bits set) if there isn't one. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Lol, Andreas already did the bottom half of the change for you. Heh, yes, I copy-and-pasted it from this patch ;-) Thanks for merging it!