From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A91C636C8 for ; Sun, 18 Jul 2021 21:31:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D91C61108 for ; Sun, 18 Jul 2021 21:31:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D91C61108 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 962D18D00F7; Sun, 18 Jul 2021 17:31:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 913218D00EC; Sun, 18 Jul 2021 17:31:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B40B8D00F7; Sun, 18 Jul 2021 17:31:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 592838D00EC for ; Sun, 18 Jul 2021 17:31:15 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F31F68249980 for ; Sun, 18 Jul 2021 21:31:13 +0000 (UTC) X-FDA: 78377004426.01.0117DF1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 3E5E450000A5 for ; Sun, 18 Jul 2021 21:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=saEY/4vR5oVUgdhiPTwdJ9ZlWWuuc9HoXDEQmM/u3RI=; b=SpOFLg8Z3oudwQfDI8th2AcBRG cyxA4iKcmxJ4ZhLHx411qiILoxlaYfk57jk//4rQpDLbsRJ9JPv5UoWg+zL6atAPMUqIBZabwFNmo ixzlJ2aHsas4CUgAsPCm5ayH6KsAMDXL8PocJ+/BIsCkTrm9G4R2oVWuYo94moamUne87giTl6CbN UMVqq7/npPjhOf5WR3mW2KBO7dBwtfV8OmUKM3N7eut0euO5Q/dikDmpDdvB8V2Fkq2bSb8aJI5jr wQWz0NkNqRcmSJeZ9BWfq6Sk3ctONHj7jPLFcVstZhavfaX4BFaQMw3Yf5dkpECzyQCfrECPJ1GOl Q4s06rwA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5ELo-006JBR-EE; Sun, 18 Jul 2021 21:29:37 +0000 Date: Sun, 18 Jul 2021 22:29:28 +0100 From: Matthew Wilcox To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Muchun Song , Yang Shi , Alex Shi , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , apopple@nvidia.com, Minchan Kim , Miaohe Lin , LKML , cgroups mailinglist , linux-mm , kernel-team Subject: Re: [PATCH v3 2/3] mm, memcg: inline mem_cgroup_{charge/uncharge} to improve disabled memcg config Message-ID: References: <20210710003626.3549282-1-surenb@google.com> <20210710003626.3549282-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SpOFLg8Z; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: iqxkmjx41fsp9pz6aawns6ojcbifr4jr X-Rspamd-Queue-Id: 3E5E450000A5 X-HE-Tag: 1626643873-148272 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 18, 2021 at 02:25:50PM -0700, Suren Baghdasaryan wrote: > On Sun, Jul 18, 2021 at 9:56 AM Matthew Wilcox wrote: > > > > On Fri, Jul 09, 2021 at 05:36:25PM -0700, Suren Baghdasaryan wrote: > > > @@ -6723,7 +6722,7 @@ static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg, > > > } > > > > > > /** > > > - * mem_cgroup_charge - charge a newly allocated page to a cgroup > > > + * __mem_cgroup_charge - charge a newly allocated page to a cgroup > > > * @page: page to charge > > > * @mm: mm context of the victim > > > * @gfp_mask: reclaim mode > > > > This patch conflicts with the folio work, so I'm just rebasing the > > folio patches on top of this, and I think this part of the patch is a > > mistake. We don't want to document the __mem_cgroup_charge() function. > > That's an implementation detail. This patch should instead have moved the > > kernel-doc to memcontrol.h and continued to document mem_cgroup_charge(). > > Ack. > There was a v4 version of this patch: > https://lore.kernel.org/patchwork/patch/1458907 which was picked up by > Andrew already. If others agree that documentation should be moved > into the header file then I'll gladly post another version. Or I can > post a separate patch moving the documentation only. Whatever works > best. Andrew, Michal, Johannes, WDYT? At this point, I've moved the documentation as part of the folio patch. I'd rather not redo that patch again ...