From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF2DC07E95 for ; Tue, 20 Jul 2021 02:00:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 07EEC61107 for ; Tue, 20 Jul 2021 02:00:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07EEC61107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9EB038D0002; Mon, 19 Jul 2021 22:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99B1B8D0001; Mon, 19 Jul 2021 22:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863478D0002; Mon, 19 Jul 2021 22:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 58F988D0001 for ; Mon, 19 Jul 2021 22:00:02 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C4B3C25F45 for ; Tue, 20 Jul 2021 02:00:00 +0000 (UTC) X-FDA: 78381310560.31.B08A14C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id BFEDEB000299 for ; Tue, 20 Jul 2021 01:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gfv4SWPihbOlBBgsVRjGneuLWlqOMg9RErJa6LM44n4=; b=TFrG9dDEmBB+ho8K4txKIUBGC9 JcN8c6U2/2/L5TGOiENqd1zd8i1vxnIA4eEpbz6l/IPJnBK6i87BtCF9wftieoKEVNO1M7xSkIfzT ZslW+SL11HiZYRD40oKPtFD7hEhD/Ky2UlY38rcc+xyLPtrZGjtzAxdfskmQcTT12SlYENkwWHaR8 PG5BRspTwpv/UJ8eiq8VCPnaaekyH1UGmNEqJcJ2wY8JHBaYdVyA7FoBC67Y3X7QWuPp2FWzPhohA a//uq+5RyKdDlw4SPh8zm/VoHmr+/x+15SMGCCn/ESPvy2S0vnuPSUj/T76a1ojR1u/SuHbhWhhKv mj6BxJ6w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5f2f-007gk1-3a; Tue, 20 Jul 2021 01:59:35 +0000 Date: Tue, 20 Jul 2021 02:59:29 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH v15 02/17] block: Add bio_for_each_folio_all() Message-ID: References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-3-willy@infradead.org> <20210720012945.GO22357@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720012945.GO22357@magnolia> Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TFrG9dDE; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: ror35n7j5k36tq3798oju7po7gx6msct X-Rspamd-Queue-Id: BFEDEB000299 X-HE-Tag: 1626746399-200279 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 06:29:45PM -0700, Darrick J. Wong wrote: > On Mon, Jul 19, 2021 at 07:39:46PM +0100, Matthew Wilcox (Oracle) wrote: > > Allow callers to iterate over each folio instead of each page. The > > bio need not have been constructed using folios originally. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Whoops, I never did remember to circle back and ack this patch. > Reviewed-by: Darrick J. Wong That's all good; it made me ask "What more can I do?" and "Add documentation" as always a good answer ...