From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3815C07E95 for ; Tue, 20 Jul 2021 11:46:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 961E06113A for ; Tue, 20 Jul 2021 11:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 961E06113A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F73F6B007B; Tue, 20 Jul 2021 07:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A68F6B00BD; Tue, 20 Jul 2021 07:46:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 147196B00C2; Tue, 20 Jul 2021 07:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id DC7EA6B007B for ; Tue, 20 Jul 2021 07:46:24 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 50DAA1836945D for ; Tue, 20 Jul 2021 11:46:23 +0000 (UTC) X-FDA: 78382788246.04.2E3CF00 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 10B94B0000B2 for ; Tue, 20 Jul 2021 11:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B8UeUwvPWcIbPtTv6nrA9hdl8FBMSvcAD7UNU1HxbHE=; b=dTe183mOvz2DghYt8e28vKt/Ix i6OcbKn4DMtq+Xb1yzaVplrZq773sF+SsV2oVctQ6383DCx2RtkCTu8WISFoTxgYoQVAbSvNvQy5H 9zlpxa8ct3v0j6Q8MEv3oQHCEoF3YZy2t5N4hHL+US2l7cBhxTB1Mn1hvliTAvuDTx+BGRs1LyJAE Ll7p2rlrARAVtOD+PkK+fqVcR0KHZdg6r4W43SB9rxrhEaRuoOJIKzQYFenYnlFAK6r4JZnEX9gCg zxKlgzqwm/QygQfqnlcvcGOHa4zpYX2rO3dPVJlxbsvAYMHr5LuXaXsvbsayUNOcNAxSmm9kc6dnU JAhv4p/Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5oBw-0083pn-2O; Tue, 20 Jul 2021 11:45:48 +0000 Date: Tue, 20 Jul 2021 12:45:40 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH v15 16/17] iomap: Convert iomap_add_to_ioend to take a folio Message-ID: References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dTe183mO; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: uqu8eyuosdd5oprnpqsi865bwu1res1r X-Rspamd-Queue-Id: 10B94B0000B2 X-HE-Tag: 1626781582-918563 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 20, 2021 at 09:20:43AM +0200, Christoph Hellwig wrote: > > /* > > - * Walk through the page to find areas to write back. If we run off the > > - * end of the current map or find the current map invalid, grab a new > > - * one. > > + * Walk through the folio to find areas to write back. If we > > + * run off the end of the current map or find the current map > > + * invalid, grab a new one. > > Why the reformatting? s/page/folio/ takes the first line over 80 columns, so pass the whole comment to 'fmt -p \*'