From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D68C07E9B for ; Tue, 20 Jul 2021 10:46:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0B3B6120D for ; Tue, 20 Jul 2021 10:46:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0B3B6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 89BF26B00CC; Tue, 20 Jul 2021 06:46:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84AF96B00CD; Tue, 20 Jul 2021 06:46:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EC946B00CE; Tue, 20 Jul 2021 06:46:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 43DEC6B00CC for ; Tue, 20 Jul 2021 06:46:44 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C846918503638 for ; Tue, 20 Jul 2021 10:46:42 +0000 (UTC) X-FDA: 78382637844.35.6E81B1C Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP id 5DFA0100A7EE for ; Tue, 20 Jul 2021 10:46:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C43E461209; Tue, 20 Jul 2021 10:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626778001; bh=NuneWne0eQvjMARQjeOYZk+gZrvufDCaE2mhrY1ue3Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbdgA6+HDrWQrdQzD/rHtgkdVnOxD5g5BKgW6IZMPket9lGlWK5TX18bTlEDVON0d JeyofqlLAiaYOjDdhzioXo8Ssp1I+4Iq/a6bPXv+tqECKtIrvjp9PA+wS7YLC5lQcV mhgEn/FzuQiPg3BC/YSN/7GK/P/bt4boUl1Fd8P5Exyj+Ei8uJm6a9fQGZ42AddIgs kCmNrfas3YHo6XS5BznMXYo3XUITmTc8G8T5SG+Is2ZL15tpA/uDcv+XCdy3hR02h7 /7/LcOLY4OkKvOLdt6uzKu1LEb9Yxv0NaV4YK/IC1IVrAmi6kdJv9ok/Ce0R0XfEZP EwQZE+FNkG7PQ== Date: Tue, 20 Jul 2021 13:46:34 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski Subject: Re: [PATCH v14 025/138] mm/writeback: Add folio_wait_writeback() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-26-willy@infradead.org> Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IbdgA6+H; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: 5geub81i1eug5du6159gj4u18zknhn1b X-Rspamd-Queue-Id: 5DFA0100A7EE X-HE-Tag: 1626778002-376682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:11AM +0100, Matthew Wilcox (Oracle) wrote: > wait_on_page_writeback_killable() only has one caller, so convert it to > call folio_wait_writeback_killable(). For the wait_on_page_writeback() > callers, add a compatibility wrapper around folio_wait_writeback(). > > Turning PageWriteback() into folio_test_writeback() eliminates a call > to compound_head() which saves 8 bytes and 15 bytes in the two > functions. Unfortunately, that is more than offset by adding the > wait_on_page_writeback compatibility wrapper for a net increase in text > of 7 bytes. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > --- > fs/afs/write.c | 9 ++++---- > include/linux/pagemap.h | 3 ++- > mm/folio-compat.c | 6 ++++++ > mm/page-writeback.c | 48 ++++++++++++++++++++++++++++------------- > 4 files changed, 46 insertions(+), 20 deletions(-) Acked-by: Mike Rapoport