From: Christoph Hellwig <hch@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] percpu: remove export of pcpu_base_addr
Date: Fri, 23 Jul 2021 06:38:31 +0100 [thread overview]
Message-ID: <YPpV15qhGLkwdzeq@infradead.org> (raw)
In-Reply-To: <20210722185814.504541-1-gregkh@linuxfoundation.org>
On Thu, Jul 22, 2021 at 08:58:14PM +0200, Greg Kroah-Hartman wrote:
> This is not needed by any modules, so remove the export.
Looks good. Note that all non-static users only want the delta,
so this could be cleaned up with a helper as well. Also
__addr_to_pcpu_ptr and __pcpu_ptr_to_addr__pcpu_ptr_to_addr are
never actually overriden by arch code, so we can remove the ifndef
there.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-07-23 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 18:58 [PATCH] percpu: remove export of pcpu_base_addr Greg Kroah-Hartman
2021-07-23 5:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPpV15qhGLkwdzeq@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).