From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3066C4338F for ; Fri, 23 Jul 2021 05:38:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3344660EB2 for ; Fri, 23 Jul 2021 05:38:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3344660EB2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 845526B005D; Fri, 23 Jul 2021 01:38:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F4B86B006C; Fri, 23 Jul 2021 01:38:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70A2D6B0070; Fri, 23 Jul 2021 01:38:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 53BB76B005D for ; Fri, 23 Jul 2021 01:38:51 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E4B03181AEF32 for ; Fri, 23 Jul 2021 05:38:50 +0000 (UTC) X-FDA: 78392748420.32.D63F1EC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 1A1C3300290C for ; Fri, 23 Jul 2021 05:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6cBwPCsOZ++wLb4UCT0Xq/SyB5mdeN8xQUIRPXaCoDw=; b=VOhiCjf23YLkFSePWt57pQ8dZR izSSgoO3gTSzOiiGbFXL1M0LXt7iUtQexBHCrVJyP3MRfO/UPnV7v/raq0X3bl4+JtRSHy0LSYRTU NKQ8BONTgWqL+/ohV3afs710vhwI7UIcIELObbP31PyzmlF8064Kt1s/5xZxOiajS6GnClJ84eKAX RIf4H5snp0qucsbaiB1zkeQ4bFlLQc0R/1hafK4moTHMVi1dVrYqPnTMnMD6d1gaiBBCy6PcCR+0h /CShgNFweWUm1cBjmVwYsPh6FNbdQZ9hF282H82fPAdHPSR0Yy8vTWkQ9Q/Jmy9afp6QpzYRj5EGm gjqOUwMw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6ntH-00B1qa-FT; Fri, 23 Jul 2021 05:38:33 +0000 Date: Fri, 23 Jul 2021 06:38:31 +0100 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] percpu: remove export of pcpu_base_addr Message-ID: References: <20210722185814.504541-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722185814.504541-1-gregkh@linuxfoundation.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VOhiCjf2; spf=none (imf09.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1A1C3300290C X-Stat-Signature: 6bz8hyg3w6d3jiip449pi7s5isiur7yt X-HE-Tag: 1627018729-64799 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 22, 2021 at 08:58:14PM +0200, Greg Kroah-Hartman wrote: > This is not needed by any modules, so remove the export. Looks good. Note that all non-static users only want the delta, so this could be cleaned up with a helper as well. Also __addr_to_pcpu_ptr and __pcpu_ptr_to_addr__pcpu_ptr_to_addr are never actually overriden by arch code, so we can remove the ifndef there. Reviewed-by: Christoph Hellwig