From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3DFFC4338F for ; Tue, 3 Aug 2021 11:38:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AAA7160C3F for ; Tue, 3 Aug 2021 11:38:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AAA7160C3F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 040006B0033; Tue, 3 Aug 2021 07:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F317C6B0036; Tue, 3 Aug 2021 07:38:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E20556B005D; Tue, 3 Aug 2021 07:38:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id C886E6B0033 for ; Tue, 3 Aug 2021 07:38:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7066A8249980 for ; Tue, 3 Aug 2021 11:38:08 +0000 (UTC) X-FDA: 78433570656.06.A879038 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id EED2B200280E for ; Tue, 3 Aug 2021 11:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n9mXEqpTfFK0JoG1V7B6cdn8c8+8uLuflTM6yqzd8eY=; b=RBuzJgSDVsCUrWyaubNCF/53jU Bq1jLXWOkOqKzACyjgGKGZh7uqcibdTYl1gXbD0O9MPsYg/TDFClSKkQGMyv4tuPSKal681jbGCHM qr0dUHnqAhOT4BW40IKIZVDo53klqEVaS/l8gWg+lI118bA0FmLBZTi+LQKaQs3bc6Oz0nKxcOVYs jlrpcfGE4SM1pjAMtTueqA/H/TwZ2EkElW2587i4n5l/2Hy718S95BbW6wMs29RiFHR1aNGV08fv/ XkwOJpnNHIC5vWmyFOsmuoBd1S3Lb6tDrTQRXRYFpHZz3W8rtZFZ4FuEeRNMXnmDW5zHnAYhoUKqY 61ji6XIw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAsiY-004a5z-BJ; Tue, 03 Aug 2021 11:36:46 +0000 Date: Tue, 3 Aug 2021 12:36:18 +0100 From: Matthew Wilcox To: Yu Zhao Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , "Kirill A . Shutemov" , Vlastimil Babka , Yang Shi , Zi Yan , linux-kernel@vger.kernel.org, Shuang Zhai Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp Message-ID: References: <20210731063938.1391602-1-yuzhao@google.com> <20210731063938.1391602-4-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210731063938.1391602-4-yuzhao@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EED2B200280E Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RBuzJgSD; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: mjo6qhts93sqjnu4z4ytk3mtdisby48p X-HE-Tag: 1627990687-813006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote: > +++ b/include/linux/rmap.h > @@ -243,7 +243,7 @@ int page_mkclean(struct page *); > */ > void page_mlock(struct page *page); > > -void remove_migration_ptes(struct page *old, struct page *new, bool locked); > +void remove_migration_ptes(struct page *old, struct page *new, bool locked, bool unmap_clean); I'm not a big fan of 'bool, bool'. Could we use a flag word instead? #define MIGRATE_REMOVE_LOCKED 1 #define MIGRATE_UNMAP_CLEAN 2