From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FF9C4338F for ; Mon, 9 Aug 2021 06:40:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B386560EE9 for ; Mon, 9 Aug 2021 06:40:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B386560EE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1EEB38D0001; Mon, 9 Aug 2021 02:40:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19EB06B0078; Mon, 9 Aug 2021 02:40:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B4918D0001; Mon, 9 Aug 2021 02:40:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id E49EC6B0075 for ; Mon, 9 Aug 2021 02:40:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 94F551E4E9 for ; Mon, 9 Aug 2021 06:40:35 +0000 (UTC) X-FDA: 78454593630.08.94824D2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id EBED08028A5F for ; Mon, 9 Aug 2021 06:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UOfsezeh2Rb2IHtiMvyy621DrExWSUzedq6b1M16AvE=; b=uzvq4Qo0mtKVu0YIlmp1mW0eek X/hjctzSksRyyLoyzQveO6Yko4Obw+RfWgBi/ltcaxWjZ6/RTyRlKUBzx7+Tt8CafYWhMz9cU+Zft 2LUQvkci7hUaizGb98YLijBrxYvPExZBLf+8Mw/peK9ipZqy7yvkYOojRYG0MsPlWp+sNAQhCRxHi mFvDlLHfozvD23UAYrLGhsrTLN7iTHkS38ZhObcEBmqweB1JJLWw4Keskwmrd3bQz8J7oxCaOwJq8 DKuz4oFxslJT5LfLzWnnrynYtfLtCHZZEAewnEe15ap6ES6twT7waZ46QeG4W2YLOuMrbBLjJthUB nZ04TlAg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCyvx-00AiNV-H2; Mon, 09 Aug 2021 06:38:56 +0000 Date: Mon, 9 Aug 2021 07:38:49 +0100 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Matthew Wilcox , LKML , linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/gup: small refactoring: simplify try_grab_page() Message-ID: References: <20210808235018.1924918-1-jhubbard@nvidia.com> <20210808235018.1924918-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210808235018.1924918-3-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EBED08028A5F Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uzvq4Qo0; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Stat-Signature: uf95xi5159yzda9jh51qoc8qqq3f544t X-HE-Tag: 1628491234-2772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 08, 2021 at 04:50:17PM -0700, John Hubbard wrote: > try_grab_page() does the same thing as try_grab_compound_head(..., > refs=1, ...), just with a different API. So there is a lot of code > duplication there. > > Change try_grab_page() to call try_grab_compound_head(), while keeping > the API contract identical for callers. > > Signed-off-by: John Hubbard > --- > mm/gup.c | 29 ++--------------------------- > 1 file changed, 2 insertions(+), 27 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 5cb18b62921c..4be6f060fa0b 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -203,33 +203,8 @@ static void put_compound_head(struct page *page, int refs, unsigned int flags) > */ > bool __must_check try_grab_page(struct page *page, unsigned int flags) > { > + if (flags & (FOLL_GET | FOLL_PIN)) > + return try_grab_compound_head(page, 1, flags) != NULL; > > return true; Nit: something like: if (!(flags & (FOLL_GET | FOLL_PIN))) return true; return try_grab_compound_head(page, 1, flags) != NULL; would be a little easier to read.