From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1274CC4338F for ; Wed, 11 Aug 2021 03:13:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD98960EC0 for ; Wed, 11 Aug 2021 03:13:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AD98960EC0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0FAB36B0071; Tue, 10 Aug 2021 23:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AB2C6B0072; Tue, 10 Aug 2021 23:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F035D6B0073; Tue, 10 Aug 2021 23:13:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id D329E6B0071 for ; Tue, 10 Aug 2021 23:13:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8C2351801F778 for ; Wed, 11 Aug 2021 03:13:32 +0000 (UTC) X-FDA: 78461329464.12.71B9C40 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 12E001004A96 for ; Wed, 11 Aug 2021 03:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+BD8bHPfSUIsdGULmpALqMFcshnOVLTSeycxgTymMVA=; b=I4xa0mmXWHwafl3+3KlzjMpsyd fUDC2rCzytydPvZwxv4eg1zjcIT9R1A8+A4HqPQ6mCODHFMqrO5Kp8ZPaAP+ny13bHGHoMgUownQV FCQ7o9P4oaCoPavC67lamAt3OnQkvedFXaLOBM89v5OJGYdsXLCEvAbWxoXakJwK6aUXlnurKFXmp qi3UHdok32ZAGR3xFE/OIZgcIm8l8Ljb/KD3cEe6/oPgki6UQNwoSVJ/VUy3AUktlr22h6CSu2/CD 4Q1Bz5hDtuBvdDL0LMnshp6wDgSyRpceeTz6kSmWn//V9ymip8+PONYeZpBihfUzvpbQl2y/RmYOp WtK6fHrA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDefG-00CtuP-Hv; Wed, 11 Aug 2021 03:12:33 +0000 Date: Wed, 11 Aug 2021 04:12:22 +0100 From: Matthew Wilcox To: David Howells Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 061/138] mm/migrate: Add folio_migrate_flags() Message-ID: References: <20210715033704.692967-62-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> <1812509.1628629765@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1812509.1628629765@warthog.procyon.org.uk> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 12E001004A96 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=I4xa0mmX; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: xsarrthn8s83s1bzb8cpnt6s6d97ncs1 X-HE-Tag: 1628651611-499026 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 10:09:25PM +0100, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > + if (folio_test_error(folio)) > > + folio_set_error(newfolio); > > + if (folio_test_referenced(folio)) > > + folio_set_referenced(newfolio); > > + if (folio_test_uptodate(folio)) > > + folio_mark_uptodate(newfolio); > > + if (folio_test_clear_active(folio)) { > > + VM_BUG_ON_FOLIO(folio_test_unevictable(folio), folio); > > + folio_set_active(newfolio); > > + } else if (folio_test_clear_unevictable(folio)) > > + folio_set_unevictable(newfolio); > > + if (folio_test_workingset(folio)) > > + folio_set_workingset(newfolio); > > + if (folio_test_checked(folio)) > > + folio_set_checked(newfolio); > > + if (folio_test_mappedtodisk(folio)) > > + folio_set_mappedtodisk(newfolio); > > Since a bunch of these are bits in folio->flags and newfolio->flags, I wonder > if it's better to do use a cmpxchg() loop or LL/SC construct to transfer all > the relevant flags in one go. I have plans for that, but they're on hold until the folio work is a bit further progressed. It also helps code that does something like: if (folio_test_dirty(folio) || folio_test_writeback(folio))