From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FA9C4338F for ; Wed, 11 Aug 2021 05:12:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F09160F13 for ; Wed, 11 Aug 2021 05:12:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F09160F13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E56A76B0071; Wed, 11 Aug 2021 01:12:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E078C6B0072; Wed, 11 Aug 2021 01:12:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1D598D0001; Wed, 11 Aug 2021 01:12:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id B5BEA6B0071 for ; Wed, 11 Aug 2021 01:12:15 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 46D8B824999B for ; Wed, 11 Aug 2021 05:12:15 +0000 (UTC) X-FDA: 78461628630.05.CFA03BB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id EEE227009EDF for ; Wed, 11 Aug 2021 05:12:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 75B2D60EB2; Wed, 11 Aug 2021 05:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628658732; bh=Z7LmDfo4zvKNkhohC0InW+SMDP5rAOUz38E0mqDCwHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=If2GrYZCsWAgUZn4dzhz/2LCPJSsKIUbL6y295qindWqzCnB0YyfeR+v2laCFsBzm apcx3Y2yNDWkVUFMLBXlJJMbmrS0WMxn4rqNf2uPrLf0XiIa4t8IaS56iSo7REHPZI hiDmPVgoxfTwcSUAdHuG/G2yBJU39eeBbsBcXNQpAsjjWWTpafVDyPXg4YVApk9Iz/ VRaZZ0dcAFvLuDTrYUFXaujZN7Mq9jufIKrodyvysk9DtREFIr6hO2G2Ku3vP7GpPZ 8/EAcjdYYoq6D5Jlqbn/eUrzaYTWCUc1WR3rbA3fGypWwPA+Y++GbWXLDHlL+7c5id CT1YfSwQyzDYQ== Date: Wed, 11 Aug 2021 08:12:06 +0300 From: Mike Rapoport To: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH 04/18] ARC: mm: remove pgd_offset_fast Message-ID: References: <20210811004258.138075-1-vgupta@kernel.org> <20210811004258.138075-5-vgupta@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811004258.138075-5-vgupta@kernel.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EEE227009EDF Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=If2GrYZC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: 5ubhi1ydb1icpy1d6uzbie9hu1o44wgg X-HE-Tag: 1628658732-957520 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 05:42:44PM -0700, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta > --- > arch/arc/include/asm/pgtable.h | 23 ----------------------- > arch/arc/mm/fault.c | 2 +- > 2 files changed, 1 insertion(+), 24 deletions(-) Shouldn't this be a part of the patch that removed usage of the scratch reg for pgd? > diff --git a/arch/arc/include/asm/pgtable.h b/arch/arc/include/asm/pgtable.h > index 0c3e220bd2b4..80b57c14b430 100644 > --- a/arch/arc/include/asm/pgtable.h > +++ b/arch/arc/include/asm/pgtable.h > @@ -284,29 +284,6 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > set_pte(ptep, pteval); > } > > -/* > - * Macro to quickly access the PGD entry, utlising the fact that some > - * arch may cache the pointer to Page Directory of "current" task > - * in a MMU register > - * > - * Thus task->mm->pgd (3 pointer dereferences, cache misses etc simply > - * becomes read a register > - * > - * ********CAUTION*******: > - * Kernel code might be dealing with some mm_struct of NON "current" > - * Thus use this macro only when you are certain that "current" is current > - * e.g. when dealing with signal frame setup code etc > - */ > -#ifdef ARC_USE_SCRATCH_REG > -#define pgd_offset_fast(mm, addr) \ > -({ \ > - pgd_t *pgd_base = (pgd_t *) read_aux_reg(ARC_REG_SCRATCH_DATA0); \ > - pgd_base + pgd_index(addr); \ > -}) > -#else > -#define pgd_offset_fast(mm, addr) pgd_offset(mm, addr) > -#endif > - > extern pgd_t swapper_pg_dir[] __aligned(PAGE_SIZE); > void update_mmu_cache(struct vm_area_struct *vma, unsigned long address, > pte_t *ptep); > diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c > index f5657cb68e4f..41f154320964 100644 > --- a/arch/arc/mm/fault.c > +++ b/arch/arc/mm/fault.c > @@ -33,7 +33,7 @@ noinline static int handle_kernel_vaddr_fault(unsigned long address) > pud_t *pud, *pud_k; > pmd_t *pmd, *pmd_k; > > - pgd = pgd_offset_fast(current->active_mm, address); > + pgd = pgd_offset(current->active_mm, address); > pgd_k = pgd_offset_k(address); > > if (!pgd_present(*pgd_k)) > -- > 2.25.1 > -- Sincerely yours, Mike.