From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA10C4338F for ; Wed, 11 Aug 2021 12:15:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D89BA60FC0 for ; Wed, 11 Aug 2021 12:15:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D89BA60FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 243B06B0071; Wed, 11 Aug 2021 08:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CB476B0072; Wed, 11 Aug 2021 08:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 092AE6B0073; Wed, 11 Aug 2021 08:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id DE80F6B0071 for ; Wed, 11 Aug 2021 08:15:23 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 76F1F1809CDEA for ; Wed, 11 Aug 2021 12:15:23 +0000 (UTC) X-FDA: 78462694926.17.40E10FA Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP id 2A4A1900800A for ; Wed, 11 Aug 2021 12:15:23 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CA16760FC3; Wed, 11 Aug 2021 12:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628684122; bh=irWqmSUH1/ML7unA3kAGPLQs6RzjTFj1LRE3RBi/7uA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HWiEn6NQt2QEye6Wzv9LpGZn4RqnIljkxxoNbuBDIu4bd3YZe+W1DYmeqtLQFUtSq 0e8yYus7TgjRw6ZrpCzOzjwimI2Us1Ot1dII3/iOUjl8lQn9UoJ3t5twgQtV/Ez3Xw +zgbPEaJhx37Ojq8iEglLqVqemr7Ve+B8vmalbMuZOJ5I3enz1cRyBYnFSld8DU0YJ BIx9lJ4Fii9axtjz7BTFuNRLDo40kAMm2TLo9aY7SsZYqo98nCYo9IwVKjyrSqlrgo 7a9xr13+/PbEGH9ZB5ajQ5eG9oPKCu/ejw/vQ/uH6nEVj8gu2JkpHKjd5T3UYbtc5G ga165PmyZH8cg== Date: Wed, 11 Aug 2021 15:15:17 +0300 From: Mike Rapoport To: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH 11/18] ARC: mm: move MMU specific bits out of entry code Message-ID: References: <20210811004258.138075-1-vgupta@kernel.org> <20210811004258.138075-12-vgupta@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811004258.138075-12-vgupta@kernel.org> Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HWiEn6NQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: hk3ngi5tttzggw71o96nc7b4go11o956 X-Rspamd-Queue-Id: 2A4A1900800A X-Rspamd-Server: rspam01 X-HE-Tag: 1628684123-480491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I believe a few words here would be useful even for the future version of yourself ;-) On Tue, Aug 10, 2021 at 05:42:51PM -0700, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta > --- > arch/arc/kernel/entry.S | 6 ------ > arch/arc/mm/tlb.c | 3 +++ > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/arc/kernel/entry.S b/arch/arc/kernel/entry.S > index 2cb8dfe866b6..684efd094520 100644 > --- a/arch/arc/kernel/entry.S > +++ b/arch/arc/kernel/entry.S > @@ -101,12 +101,6 @@ ENTRY(EV_MachineCheck) > lr r0, [efa] > mov r1, sp > > - ; hardware auto-disables MMU, re-enable it to allow kernel vaddr > - ; access for say stack unwinding of modules for crash dumps > - lr r3, [ARC_REG_PID] > - or r3, r3, MMU_ENABLE > - sr r3, [ARC_REG_PID] > - > lsr r3, r2, 8 > bmsk r3, r3, 7 > brne r3, ECR_C_MCHK_DUP_TLB, 1f > diff --git a/arch/arc/mm/tlb.c b/arch/arc/mm/tlb.c > index b68d5798327b..34f16e0b41e6 100644 > --- a/arch/arc/mm/tlb.c > +++ b/arch/arc/mm/tlb.c > @@ -813,5 +813,8 @@ void do_tlb_overlap_fault(unsigned long cause, unsigned long address, > } > } > > + /* Re-enable MMU as hardware may have auto-disabled it upon exception */ > + write_aux_reg(ARC_REG_PID, read_aux_reg(ARC_REG_PID) | MMU_ENABLE); > + > local_irq_restore(flags); > } > -- > 2.25.1 > -- Sincerely yours, Mike.