From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=m6BX=NQ=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D7B61C432BE
	for <linux-mm@archiver.kernel.org>; Wed, 25 Aug 2021 19:16:30 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id DCF1D60F35
	for <linux-mm@archiver.kernel.org>; Wed, 25 Aug 2021 19:16:28 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DCF1D60F35
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org
Received: by kanga.kvack.org (Postfix)
	id 1FEEA6B006C; Wed, 25 Aug 2021 15:16:28 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 188F88D0001; Wed, 25 Aug 2021 15:16:28 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 051346B0073; Wed, 25 Aug 2021 15:16:27 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157])
	by kanga.kvack.org (Postfix) with ESMTP id DB5926B006C
	for <linux-mm@kvack.org>; Wed, 25 Aug 2021 15:16:27 -0400 (EDT)
Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay05.hostedemail.com (Postfix) with ESMTP id 5FD42181352A5
	for <linux-mm@kvack.org>; Wed, 25 Aug 2021 19:16:27 +0000 (UTC)
X-FDA: 78514559214.28.FE355FC
Received: from casper.infradead.org (casper.infradead.org [90.155.50.34])
	by imf14.hostedemail.com (Postfix) with ESMTP id ED5C0600198F
	for <linux-mm@kvack.org>; Wed, 25 Aug 2021 19:16:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
	References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=vnK5hFrC8B8FFVr6MsO2gBo3ffuSh4w2DLgihKVUK6M=; b=cmBRpgWdWjBIMPIsvZrzbol9Hw
	yO76NUo2Jd8uNlz+kXHIw45BDSGZigykP7lPwGDwXH2zO0IdX++vbdCKGa2A/KcQmthtZCSeBcDQJ
	5F2Z/uCa0cXVH461xd7dwrhJ8NhEsLIeoxXI3KTbDNYsXhCEbKb3JTa5leBFFgq+dwEnt3RnWpT+p
	qH8irJsTwDEssqCfjg5xqf5chSaiZ65QoB+qDDtlYxe+Y86IhjaJ2B8HHEr8Gd2tSUfehvtCi5Wye
	M4UnPFiO2GqoJSj/LXl26cUJSMWFkG2ICuRuMIyYl1Fzg+VEho/h/q2GsT6Ke8d3ykf+mPkefceWo
	qkWGbKzg==;
Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
	id 1mIyNC-00Cb3F-Hj; Wed, 25 Aug 2021 19:15:52 +0000
Date: Wed, 25 Aug 2021 20:15:42 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: Dan Williams <dan.j.williams@intel.com>, Linux MM <linux-mm@kvack.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Naoya Horiguchi <naoya.horiguchi@nec.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, John Hubbard <jhubbard@nvidia.com>,
	Jane Chu <jane.chu@oracle.com>,
	Muchun Song <songmuchun@bytedance.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Linux NVDIMM <nvdimm@lists.linux.dev>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v3 13/14] mm/gup: grab head page refcount once for group
 of subpages
Message-ID: <YSaW3kkcwATVtbVv@casper.infradead.org>
References: <20210714193542.21857-1-joao.m.martins@oracle.com>
 <20210714193542.21857-14-joao.m.martins@oracle.com>
 <CAPcyv4i_BbQn6WkgeNq5kLeQcMu=w4GBdrBZ=YbuYnGC5-Dbiw@mail.gmail.com>
 <861f03ee-f8c8-cc89-3fc2-884c062fea11@oracle.com>
 <CAPcyv4gkxysWT60P_A+Q18K=Zc9i5P6u69tD5g9_aLV=TW1gpA@mail.gmail.com>
 <21939df3-9376-25f2-bf94-acb55ef49307@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21939df3-9376-25f2-bf94-acb55ef49307@oracle.com>
Authentication-Results: imf14.hostedemail.com;
	dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cmBRpgWd;
	spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org;
	dmarc=none
X-Rspamd-Server: rspam02
X-Rspamd-Queue-Id: ED5C0600198F
X-Stat-Signature: 5mnfuwkqm3t18p4zfwdcir75gfj1fgkf
X-HE-Tag: 1629918986-8978
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Wed, Aug 25, 2021 at 08:10:39PM +0100, Joao Martins wrote:
> @@ -2273,8 +2273,7 @@ static int __gup_device_huge(unsigned long pfn, unsigned long addr,
>                 refs = record_subpages(page, addr, next, pages + *nr);
> 
>                 SetPageReferenced(head);
> -               pinned_head = try_grab_compound_head(head, refs, flags);
> -               if (unlikely(!pinned_head)) {
> +               if (unlikely(!try_grab_compound_head(head, refs, flags))) {
>                         if (PageCompound(head))

BTW, you can just check PageHead(head).  We know it can't be PageTail ...