From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBECDC433FE for ; Fri, 10 Sep 2021 12:00:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8EB57610E9 for ; Fri, 10 Sep 2021 12:00:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8EB57610E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 13E206B0071; Fri, 10 Sep 2021 08:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EE426B0072; Fri, 10 Sep 2021 08:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1DBC900002; Fri, 10 Sep 2021 08:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id E01E56B0071 for ; Fri, 10 Sep 2021 08:00:14 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8A3CF8249980 for ; Fri, 10 Sep 2021 12:00:14 +0000 (UTC) X-FDA: 78571520748.37.7741B99 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP id 3D3E8D02AFA7 for ; Fri, 10 Sep 2021 12:00:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B11A1610E9; Fri, 10 Sep 2021 12:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631275213; bh=tRwIMvcqHBtl6NN8nVb5EPlc3v7U/VgT8RGPiEAz7WI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CUnOlhdGFn45GDr5Z6t2czKozUb/+Y7u021g5sBBRnvMgpbfhfFes68G1dMEAfSdV UEKBNmLSJg2DXmnKCP+hG1txpqHw7zRFOUjgeJ42jsoL8V4kVxFlAgoWgIwhmIdCUu hDB/fGPMn99x9H00RK1aNOqOjWcY2z+ui+fuk+B8I7lT5D2SFwe5unD7w8IwC2Tzrb eL5XJM5TrgfelBfIDxqfhlQzQhtSW3epgYYCiYxMVJEp77VJ6a1GIqgj5CSx3fdC7G 6tEWepPpijlR5L4DBIICsVHU3XAwBCqNk1+WiYXnbnvk/tutVXxBeB3tbadQsB//1f gyVni3bPTYiSA== Date: Fri, 10 Sep 2021 15:00:05 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Andrew Morton , adobriyan@gmail.com, chenying.kernel@bytedance.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, songmuchun@bytedance.com, torvalds@linux-foundation.org, zhouchengming@bytedance.com, zhoufeng.zf@bytedance.com Subject: Re: [patch 079/147] fs/proc/kcore.c: add mmap interface Message-ID: References: <20210908025730.S88ylmikU%akpm@linux-foundation.org> <303e9a27-7495-1c94-64a1-a1149a39f0a9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <303e9a27-7495-1c94-64a1-a1149a39f0a9@redhat.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3D3E8D02AFA7 X-Stat-Signature: c6xtsi1r6ke1c9au9ogikgf1w637foj3 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CUnOlhdG; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1631275214-32998 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 10, 2021 at 12:08:17PM +0200, David Hildenbrand wrote: > On 08.09.21 04:57, Andrew Morton wrote: > > + > > + if (vma->vm_flags & (VM_WRITE | VM_EXEC)) { > > + ret = -EPERM; > > + goto out; > > + } > > + > > + vma->vm_flags &= ~(VM_MAYWRITE | VM_MAYEXEC); > > + vma->vm_flags |= VM_MIXEDMAP; > > + vma->vm_ops = &kcore_mmap_ops; > > + > > This breaks all my efforts to sanitize /proc/kore access for virtio-mem. > > Is there still a way to nack this? Already done: https://lore.kernel.org/mm-commits/CAHk-=wgQ+8kmczLLKCY7yDsGHQBRcZESKd1dNaKbrjUgbWeb3A@mail.gmail.com and down the same thread. > Sorry I didn't spot this any sooner. > > -- > Thanks, > > David / dhildenb > -- Sincerely yours, Mike.