From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46D8C433F5 for ; Fri, 17 Sep 2021 21:17:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5FE3D611C8 for ; Fri, 17 Sep 2021 21:17:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5FE3D611C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B8A146B0071; Fri, 17 Sep 2021 17:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3A056B0072; Fri, 17 Sep 2021 17:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A01A2900002; Fri, 17 Sep 2021 17:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 8F1236B0071 for ; Fri, 17 Sep 2021 17:17:13 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 330FF39B38 for ; Fri, 17 Sep 2021 21:17:13 +0000 (UTC) X-FDA: 78598325946.36.E05F42F Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf16.hostedemail.com (Postfix) with ESMTP id D2A8AF0000A0 for ; Fri, 17 Sep 2021 21:17:12 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id 73so16636577qki.4 for ; Fri, 17 Sep 2021 14:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JGV/tPQh6K9SXsu6M8jwp1WUGbsoN50z6xi39yPO454=; b=Smgw4tU6Y4AxmzVm12rd2uvBzsJ9XKtA0olWaSdDsaRXQKeElaIsp2OqqGviHxTJkg OAgrbvvrD6gh5RF2rhkyrZ7AINWX8k6T2Z7pjJpevKa/rZF4auBZYbqHKT1Z9Zwun9jp STY8SzKEWAhS5p/gpq/JulNTUICyZgiNH7EaHF+cin4kSJPyl47n03nmFWGznGHcv5PN pBRzZQesmft1Z72Of0Ronwya3/SPAnNwz1siGoGBmfaoy6Y/leHKTkTmf+MUqknvIuO7 orzPlAJBgnRoQSu7KDOgDcR2OUO56LAoLm57n4uFBOD+cXFFgEGCIZ7eu6yF4yLdgiZ/ n62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JGV/tPQh6K9SXsu6M8jwp1WUGbsoN50z6xi39yPO454=; b=RDZUtKNhH4G94WzU/KA/FyGqZmMydEdW4/AyI2thWTqy/bhJKEuNYAnCC5loJVtuOg PumlgpavuhTropO7QrWITajm3bNc+ojfMXLbdgby1Ho59rWNWbVUnIFpezfmRzG6LfWI VoghKeNN25NZ7zHdfrodY3oX7gqYYhTnPG5yJB754tIZOJk8+h1mJIRZuzQrWAUpIItV Wv366RWdCEeczbdXlX/KbEfq1iKvHQo4jsOmEjSkY8l+0Sl1SjCAj4Okc2wn/CP797Un ECGOpK/w50to0tThM/xI/oduMjjnWFYWrnoSZ+3YkGn5G0lQSWgbWPrwRNMSVYHo+zOL EJtw== X-Gm-Message-State: AOAM530fhSWSz3p+TtRtrf343fKhoYA/NXsmjB0q6hWes10uMiG4+nNe KIQBAoh2kp3RheR8YJkIvA== X-Google-Smtp-Source: ABdhPJzghVCbWAFxTuwjujq3dGdZrFkmoJ7O+Xlmc64lIjwI4sM5JnmspEziweAuTU6B7uzR4GB3rw== X-Received: by 2002:a37:ab0d:: with SMTP id u13mr12597365qke.521.1631913432191; Fri, 17 Sep 2021 14:17:12 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id m139sm4768882qke.18.2021.09.17.14.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 14:17:11 -0700 (PDT) Date: Fri, 17 Sep 2021 17:17:09 -0400 From: Kent Overstreet To: "Kirill A. Shutemov" Cc: Johannes Weiner , Dave Chinner , "Darrick J. Wong" , Matthew Wilcox , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Christoph Hellwig , David Howells Subject: Re: Folio discussion recap Message-ID: References: <20210916025854.GE34899@magnolia> <20210917052440.GJ1756565@dread.disaster.area> <20210917205735.tistsacwwzkcdklx@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210917205735.tistsacwwzkcdklx@box.shutemov.name> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D2A8AF0000A0 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Smgw4tU6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Stat-Signature: 8mpcxobnyk9twehutow5h6ymrotapqta X-HE-Tag: 1631913432-450233 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 17, 2021 at 11:57:35PM +0300, Kirill A. Shutemov wrote: > On Fri, Sep 17, 2021 at 12:31:36PM -0400, Johannes Weiner wrote: > > I didn't suggest to change what the folio currently already is for the > > page cache. I asked to keep anon pages out of it (and in the future > > potentially other random stuff that is using compound pages). > > It would mean that anon-THP cannot benefit from the work Willy did with > folios. Anon-THP is the most active user of compound pages at the moment > and it also suffers from the compound_head() plague. You ask to exclude > anon-THP siting *possible* future benefits for pagecache. > > Sorry, but this doesn't sound fair to me. I'm less concerned with what's fair than figuring out what the consensus is so we can move forward. I agree that anonymous THPs could benefit greatly from conversion to folios - but looking at the code it doesn't look like much of that has been done yet. I understand you've had some input into the folio patches, so maybe you'd be best able to answer while Matthew is away - would it be fair to say that, in the interests of moving forward, anonymous pages could be split out for now? That way the MM people gain time to come to their own consensus and we can still unblock the FS work that's already been done on top of folios.