From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC451C433F5 for ; Wed, 13 Oct 2021 02:41:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50D3C60041 for ; Wed, 13 Oct 2021 02:41:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50D3C60041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8F28B6B006C; Tue, 12 Oct 2021 22:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A1586B0071; Tue, 12 Oct 2021 22:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79164900002; Tue, 12 Oct 2021 22:41:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 6BA256B006C for ; Tue, 12 Oct 2021 22:41:09 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 32B6E2D388 for ; Wed, 13 Oct 2021 02:41:09 +0000 (UTC) X-FDA: 78689862258.25.757D5EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id CAEB4103A1BF for ; Wed, 13 Oct 2021 02:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634092868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ft1VC9zrQcW79FB0tNwhaRoMQpMWx16xNlQ9+j3yL0Q=; b=OLZfSMJwGcdFd1OaJkhLELknSJA0auwbTqfYT0N1wHlArQNNKYh0mNK+eAjJyUJq4NJ9p8 5imoQ4BvilBjjuTBKmdt3OgVxnLdlg1/KGEWTcwblYB6w/wwjIgvYKf3FYCx5b13yRf+xr gnEsIFAXhEiHqwgCaHLRHznK2vGyjas= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-YjSaWywSOeiTrzyW8KCsoA-1; Tue, 12 Oct 2021 22:41:06 -0400 X-MC-Unique: YjSaWywSOeiTrzyW8KCsoA-1 Received: by mail-pl1-f197.google.com with SMTP id e6-20020a170902ed8600b0013f165d1b51so323952plj.15 for ; Tue, 12 Oct 2021 19:41:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ft1VC9zrQcW79FB0tNwhaRoMQpMWx16xNlQ9+j3yL0Q=; b=D+IhvUZQ4v9UH0j/TxyH7zO5fFT36+I5S19HeUhSuzaIDQiLVMsaWnavYO4bU4OssZ xDFHEhq2jcZg08Qzwn7Llm9CDxpe2cUbkZcVb9ZwhRd0xgkZgncka90zx5DFcj9xJYuJ cHQmxrD8m0qO2hLK45Bs8a+dVGvq7l8UK8LVdHwvlssn98RNkERBgeA28YvObuqO8w2A Pt5ODKeN0A9WWx+s8PpjPt/IFNFnBv7uZzpTBDqPyEwZnhzH2KcjfYYImXVs+HJxbx6e vQ4Wl4310O+beOTSe9p1tPzKtVPZtFKQP7G2pzq2AfKa1No/tvfDArk40Usm4xuM7+Tr 300A== X-Gm-Message-State: AOAM531gLnODUdnRvu0h5wkpZgsZ7L4PI0tzMYWQX9RR2ZTi9ClXR5b+ OkZT4DAMFKvUlg+baljuBGvOgd/Y3FfS0I94d7ZAjMXNI/o6aDEeYKl8gilzDVLtlL7Wcw1yHvu l3m1SOjyxstA= X-Received: by 2002:a17:90a:8b89:: with SMTP id z9mr10389120pjn.89.1634092865742; Tue, 12 Oct 2021 19:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv4fE/XpKqdSojl1JvafE8JRzpy63XtSbqmEDaHX4njX6bFnlJqEI2qmA63YhiSVFaEXHm+w== X-Received: by 2002:a17:90a:8b89:: with SMTP id z9mr10389092pjn.89.1634092865381; Tue, 12 Oct 2021 19:41:05 -0700 (PDT) Received: from t490s ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p18sm12844157pgk.28.2021.10.12.19.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 19:41:04 -0700 (PDT) Date: Wed, 13 Oct 2021 10:40:57 +0800 From: Peter Xu To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v3 PATCH 0/5] Solve silent data loss caused by poisoned page cache (shmem/tmpfs) Message-ID: References: <20210930215311.240774-1-shy828301@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210930215311.240774-1-shy828301@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CAEB4103A1BF X-Stat-Signature: ycn36cxoxuh8byyoxr3cw5xq7s8i5kf4 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OLZfSMJw; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf13.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1634092868-309180 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 30, 2021 at 02:53:06PM -0700, Yang Shi wrote: > Yang Shi (5): > mm: hwpoison: remove the unnecessary THP check > mm: filemap: check if THP has hwpoisoned subpage for PMD page fault > mm: hwpoison: refactor refcount check handling > mm: shmem: don't truncate page if memory failure happens > mm: hwpoison: handle non-anonymous THP correctly Today I just noticed one more thing: unpoison path has (unpoison_memory): if (page_mapping(page)) { unpoison_pr_info("Unpoison: the hwpoison page has non-NULL mapping %#lx\n", pfn, &unpoison_rs); return 0; } I _think_ it was used to make sure we ignore page that was not successfully poisoned/offlined before (for anonymous), so raising this question up on whether we should make sure e.g. shmem hwpoisoned pages still can be unpoisoned for debugging purposes. -- Peter Xu