Re: [PATCH nf-next] netfilter: core: Fix clang warnings about unused static inlines

Pablo Neira Ayuso
2021-10-17T13:48:29Z

On Sat, Oct 16, 2021 at 10:13:27AM +0200, Lukas Wunner wrote:
> Unlike gcc, clang warns about unused static inlines that are not in an
> include file:
>
> net/netfilter/core.c:344:20: error: unused function 'nf_ingress_hook' [-Werror,-Wunused-function]
> static inline bool nf_ingress_hook(const struct nf_hook_ops *reg, int pf)
> ^
> net/netfilter/core.c:353:20: error: unused function 'nf_egress_hook' [-Werror,-Wunused-function]
> static inline bool nf_egress_hook(const struct nf_hook_ops *reg, int pf)
> ^
>
> According to commit 6863f5643dd7 ("kbuild: allow Clang to find unused
> static inline functions for W=1 build"), the proper resolution is to
> mark the affected functions as __maybe_unused. An alternative approach
> would be to move them to include/linux/netfilter_netdev.h, but since
> Pablo didn't do that in commit ddcfa710d40b ("netfilter: add
> nf_ingress_hook() helper function"), I'm guessing __maybe_unused is
> preferred.
>
> This fixes both the warning introduced by Pablo in v5.10 as well as the
> one recently introduced by myself with commit 42df6e1d221d ("netfilter:
> Introduce egress hook").

Applied, thanks.