From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC94DC433EF for ; Wed, 20 Oct 2021 17:46:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8BFF3611F2 for ; Wed, 20 Oct 2021 17:46:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8BFF3611F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 27823900005; Wed, 20 Oct 2021 13:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 226F9900003; Wed, 20 Oct 2021 13:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 115E6900005; Wed, 20 Oct 2021 13:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 02998900003 for ; Wed, 20 Oct 2021 13:46:29 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B99202AEFD for ; Wed, 20 Oct 2021 17:46:28 +0000 (UTC) X-FDA: 78717545256.34.C7A371E Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf09.hostedemail.com (Postfix) with ESMTP id 6061E3000105 for ; Wed, 20 Oct 2021 17:46:26 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id b12so3762579qtq.3 for ; Wed, 20 Oct 2021 10:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0QHGLrhaXKpKpvs2TLQ73EmV4pXkj4boxSmu6rBcYBI=; b=QC2enIqbJU5zyGxfY2qJ+RKsttNvVlJw5ESsHPsKytBXHbft+70CDnDsgh+ktV9nVS Ts3CB7N1bU+AWe+OoT1iNM1fQ7/Qz03jgjrlfO6mTCuZabvAu2CTXBiv0diXxQVvVGVk tDHB0EB6JbKCWxoyYxuB9QQyvD6xB1Qi2j7kE9xm7LZ17SgKzSbWEMakcDG4qMGJPnOv hBD3LuP4H/LBxZUatwQPeZrFAdGd5Xptq6oi41LeQvkwpetKYmVpWDMnscZlq02PvGan not7BsHZ+nPN45uw0swS3CzZwxDbqsaoG6TG8P7RztE2ss7m9HtkojuZWMZ1xdmpGkv7 Ii3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0QHGLrhaXKpKpvs2TLQ73EmV4pXkj4boxSmu6rBcYBI=; b=KU9iwpBaDCWSTdty7bJlHbTlK2HqJ38uXzXSDMpPnUduLepL/owMsTyz8FeCLwOqfb ijbp+0jCsZHqYLkl0LcPUW021TNUp678NpQvEHwF5cTrJ9pIXAb0oajlaUb+AzRaXxpE /ZeOdCrXyDwY0YP/IwC6gU9zKwHAlZYnNWvsqjx0yu85AJIdJscrZ5HNCoFZvWX/N/JY f9zdk6DNXZFBGXFuDVeEXAKiwwdNJXYTXlTDmXz6nUuc+m9kQaskBefLewb0HfwBFw9F PIEmHh+z7gBT7jSPWA+M8iGiwRDdFYhG//FAjiKvCkU3pnxy8KdRgROuWyC2FLI1LUZx c2tA== X-Gm-Message-State: AOAM532pm4Q6swQ2R1co1z6DJIfjBICI5wJOqs/JCDaeE1LykNxH9QJC 1LEsgZwX2RLPhplyWIjdwg== X-Google-Smtp-Source: ABdhPJxvVuQj4BfHA6bCmmzmmBWzVAvnlqxouqMH/WH0eCclkcW4pXMJyOWKO5jl7FEMLmODG9nAIQ== X-Received: by 2002:ac8:7458:: with SMTP id h24mr550357qtr.355.1634751987832; Wed, 20 Oct 2021 10:46:27 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id j184sm1326545qkd.74.2021.10.20.10.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 10:46:27 -0700 (PDT) Date: Wed, 20 Oct 2021 13:46:25 -0400 From: Kent Overstreet To: Matthew Wilcox , Johannes Weiner , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , "Darrick J. Wong" , Christoph Hellwig , David Howells Subject: Re: Splitting struct page into multiple types - Was: re: Folio discussion recap - Message-ID: References: <20211019170603.GA15424@hsiangkao-HP-ZHAN-66-Pro-G1> <20211019175419.GA22532@hsiangkao-HP-ZHAN-66-Pro-G1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019175419.GA22532@hsiangkao-HP-ZHAN-66-Pro-G1> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6061E3000105 X-Stat-Signature: c7uj43ouni8t4r9wy3mx6xgqisuuz4ym Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QC2enIqb; spf=pass (imf09.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1634751986-875702 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 20, 2021 at 01:54:20AM +0800, Gao Xiang wrote: > On Tue, Oct 19, 2021 at 06:34:19PM +0100, Matthew Wilcox wrote: > > It looks like this will be quite a large change to how erofs handles > > compressed blocks, but if you're open to taking this on, I'd be very happy. > > For ->lru, it's quite small, but it sacrifices the performance. Yet I'm > very glad to do if some decision of this ->lru field is determined. I would be very appreciative if you were willing to do the work, and I know others would be too. These kinds of cleanups may seem small individually, but they make a _very_ real difference when we're looking kernel-wide at how possible these struct page changes may be - and even if they don't happen, it really helps understandability of the code if we can move towards a single struct field always being used for a single purpose in our core data types.