From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA88C43217 for ; Fri, 12 Nov 2021 18:56:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C668961051 for ; Fri, 12 Nov 2021 18:56:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C668961051 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2CDDE6B0075; Fri, 12 Nov 2021 13:56:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27C666B0078; Fri, 12 Nov 2021 13:56:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192306B007B; Fri, 12 Nov 2021 13:56:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 083926B0075 for ; Fri, 12 Nov 2021 13:56:30 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A8781777E4 for ; Fri, 12 Nov 2021 18:56:29 +0000 (UTC) X-FDA: 78801184098.24.0D7CF0D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id B11EE5096F15 for ; Fri, 12 Nov 2021 18:56:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F195A60F93; Fri, 12 Nov 2021 18:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636743388; bh=D1rXtDqoJhaQG2E/xRhBx3f6tZ2CC1AU4VZeakU4NHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z8YcLZD6kjgh7/4hm30vXdlHY9oApUE+tnDU+KggGsZd7BC71Nlfiwl7vMC95vghW +rEhxKgVJAdy+4P4NLBzc5no3CXGj90Uf6/U5hm+Zau84epTA7pqMtY3PFiFNFECiW t5rIhktfsToMAXf0fYa7enbx0kOpWWKKbmd4sJQtGhe3bb458MODcsXugAuizWljXf ykmKhwrLlc2gXbCjsRe3uPplWLfvi0ou0UqWYqZXAbGhXFeNu9TcWAA8dafCcs/QB+ 5hUBSy+7UKgH0rsIw4sGt65Rw8FivQNDCeywxsBhyAT0/5cidw0qASeLiWaXoug2Jr ZFIzfJKamp1Ew== Date: Fri, 12 Nov 2021 10:56:26 -0800 From: Eric Biggers To: Roberto Sassu Cc: tytso@mit.edu, corbet@lwn.net, viro@zeniv.linux.org.uk, hughd@google.com, akpm@linux-foundation.org, linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 4/5] shmem: Avoid segfault in shmem_read_mapping_page_gfp() Message-ID: References: <20211112124411.1948809-1-roberto.sassu@huawei.com> <20211112124411.1948809-5-roberto.sassu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211112124411.1948809-5-roberto.sassu@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B11EE5096F15 X-Stat-Signature: 7kd8szrom3i3r9icp6awidinpooeqxjc Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z8YcLZD6; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of ebiggers@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=ebiggers@kernel.org X-HE-Tag: 1636743366-719117 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001153, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 12, 2021 at 01:44:10PM +0100, Roberto Sassu wrote: > Check the hwpoison page flag only if the page is valid in > shmem_read_mapping_page_gfp(). The PageHWPoison() macro tries to access > the page flags and cannot work on an error pointer. > > Signed-off-by: Roberto Sassu This looks like a recent regression from the commit: commit b9d02f1bdd98f38e6e5ecacc9786a8f58f3f8b2c Author: Yang Shi Date: Fri Nov 5 13:41:10 2021 -0700 mm: shmem: don't truncate page if memory failure happens Can you please send this fix out as a standalone patch, to the right people and including the appropriate "Fixes" tag? - Eric