From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F99CC433F5 for ; Fri, 12 Nov 2021 18:15:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5D7061054 for ; Fri, 12 Nov 2021 18:15:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B5D7061054 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2A8896B0075; Fri, 12 Nov 2021 13:15:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2586C6B0078; Fri, 12 Nov 2021 13:15:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 147696B007B; Fri, 12 Nov 2021 13:15:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 0287A6B0075 for ; Fri, 12 Nov 2021 13:15:54 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A783654C98 for ; Fri, 12 Nov 2021 18:15:54 +0000 (UTC) X-FDA: 78801081828.16.C8A54A7 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf22.hostedemail.com (Postfix) with ESMTP id 2AB2C192D for ; Fri, 12 Nov 2021 18:15:54 +0000 (UTC) Received: by mail-qv1-f48.google.com with SMTP id j9so6817799qvm.10 for ; Fri, 12 Nov 2021 10:15:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cop4I1aJy8z6ak0PjU3E7DI7v06o5jsLWL60m/FXBfk=; b=3QOYUTLbg1wTI9c7KmmkC0XzfQR96w+LrDXJvXE+JmHJJFv0ErBi1hMADiVaFYWV3D fiaWtKtH4uy5NFSH/eIPdz7eYjL+tvS0uIhjLbd1l8zcNzm18JsjvU6f1+TH8u775Lmf 3uJQmMTL++Vv6VuDCH06SAlADEqjelfJiRfesjot5WmsWUOGTuWIzDqLvGOCnSjObM2q SkpW1oHRbV09OZPZTLcyoeLrgSFu1IG5Fnlri1nR4E/J1rcLuxEX5am3RBZgvCiSOSLz FxtfFAhBVhALib4X8gM5qDsyAHRc3otl7PFwSOieBtRygQv3MrJLRnq76KuYHAfZiwTT UbHw== X-Gm-Message-State: AOAM531QkMLxug83+1deGQlH6+dlphati85tSGP7wUkJ4kxtvIvFxIGN aM7wbFOK9/4ymUiNi1oiFA8= X-Google-Smtp-Source: ABdhPJyOaTMeyqagIIw4gBdML86eGkUddV2vICZg3GXua3oB54KGmh7wnYdATKXU8i8nGv70D94D0w== X-Received: by 2002:a0c:eec3:: with SMTP id h3mr16595518qvs.17.1636740953456; Fri, 12 Nov 2021 10:15:53 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id l15sm3592323qtx.77.2021.11.12.10.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 10:15:52 -0800 (PST) Date: Fri, 12 Nov 2021 13:15:51 -0500 From: Dennis Zhou To: Andy Shevchenko , Andrew Morton Cc: Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dennis Zhou , Tejun Heo , Christoph Lameter , Petr Mladek , Steven Rostedt Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h Message-ID: References: <20211112140749.80042-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211112140749.80042-1-andriy.shevchenko@linux.intel.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2AB2C192D X-Stat-Signature: nduefd93wtua4xcnn3o8984cg7cxtpn9 Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-HE-Tag: 1636740954-209637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote: > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > in NMI") the printk.h is not needed anymore in percpu.h. > > Moreover `make headerdep` complains (an excerpt) > > In file included from linux/printk.h, > from linux/dynamic_debug.h:188 > from linux/printk.h:559 <-- here > from linux/percpu.h:9 > from linux/idr.h:17 > include/net/9p/client.h:13: warning: recursive header inclusion > > Yeah, it's not a root cause of this, but removing will help to reduce > the noise. > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk in NMI") > Signed-off-by: Andy Shevchenko > --- > include/linux/percpu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/percpu.h b/include/linux/percpu.h > index 98a9371133f8..ae4004e7957e 100644 > --- a/include/linux/percpu.h > +++ b/include/linux/percpu.h > @@ -6,7 +6,6 @@ > #include > #include > #include > -#include > #include > #include > > -- > 2.33.0 > Acked-by: Dennis Zhou Hey Andrew, it doesn't seem like I have anything big coming through percpu, do you mind taking this. I might have some stuff due to sh, but I'm still working on that with them. Thanks, Dennis