From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37682C433F5 for ; Mon, 15 Nov 2021 15:04:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D93B061A40 for ; Mon, 15 Nov 2021 15:04:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D93B061A40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6C71F6B0078; Mon, 15 Nov 2021 10:04:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 676C26B007B; Mon, 15 Nov 2021 10:04:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565716B007E; Mon, 15 Nov 2021 10:04:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 439B76B0078 for ; Mon, 15 Nov 2021 10:04:33 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EC3457F90E for ; Mon, 15 Nov 2021 15:04:32 +0000 (UTC) X-FDA: 78811485984.30.72D9C53 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf18.hostedemail.com (Postfix) with ESMTP id 24D5B4002099 for ; Mon, 15 Nov 2021 15:04:31 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id p4so8728916qkm.7 for ; Mon, 15 Nov 2021 07:04:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4ywlZ6ivBrVweqme2JRtHcgtd2wHVvwsW9gDLxTi7uU=; b=7pX1EOGQOIYsq+p3ptl/5unsqF2bpZ86kxH+Iww2b+xDJPRK2xv3NN4LAuInKXEY6q XGSn6zFRre9uHK5Fgsi6PlYVxJ5mAY0dtTqfbLBjteYgLMBpYJKp+mLlkpZb8bcMt6ZI JO1xkghZxp1v8rb9LPxZ3srcM68TiacfT49FWzH0XZvSXg6DsefLmn+NHN1SpXHSFkey CnhtPkmX5EvkqYnJHztQlROZ44GvLW7/okSCSpztbNKYrGhB+JknxCR5MfIPKSEM8NTL 9USfBwE+rRu2ncMu/OYxrc8p0VQUCYDIzZ9+hVHVt+NPQmW3iKTqQ/eD9+FKOq1r2QYk Czow== X-Gm-Message-State: AOAM531hIFUyq882jYh2v2svLhaUAcejAOBA8UYPF4jfOVx/F+8otWR7 u2BavYxZg9fYf/XaFFBzcV8= X-Google-Smtp-Source: ABdhPJyjlP71OZgSnFmrs9IPwOeuByfzPFgePjHyk+E3t/coLIU2EX0N6f4TTrKVMRHn/LPNGadwyg== X-Received: by 2002:a05:620a:4622:: with SMTP id br34mr29018631qkb.504.1636988670389; Mon, 15 Nov 2021 07:04:30 -0800 (PST) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id g21sm6520756qtb.62.2021.11.15.07.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 07:04:29 -0800 (PST) Date: Mon, 15 Nov 2021 10:04:27 -0500 From: Dennis Zhou To: Petr Mladek Cc: Andy Shevchenko , Dennis Zhou , Andrew Morton , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Steven Rostedt Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h Message-ID: References: <20211112140749.80042-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.222.181 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 24D5B4002099 X-Stat-Signature: ghj7mmcsf1uipjy4o3nrht633b76o84s X-HE-Tag: 1636988671-49021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 15, 2021 at 03:34:04PM +0100, Petr Mladek wrote: > On Mon 2021-11-15 14:57:30, Petr Mladek wrote: > > On Mon 2021-11-15 12:38:03, Andy Shevchenko wrote: > > > On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote: > > > > On Fri 2021-11-12 13:15:51, Dennis Zhou wrote: > > > > > On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote: > > > > > > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > > > > in NMI") the printk.h is not needed anymore in percpu.h. > > > > > > > > > > > > Moreover `make headerdep` complains (an excerpt) > > > > > > > > > > > > In file included from linux/printk.h, > > > > > > from linux/dynamic_debug.h:188 > > > > > > from linux/printk.h:559 <-- here > > > > > > from linux/percpu.h:9 > > > > > > from linux/idr.h:17 > > > > > > include/net/9p/client.h:13: warning: recursive header inclusion > > > > > > > > > > > > Yeah, it's not a root cause of this, but removing will help to reduce > > > > > > the noise. > > > > > > > > > > > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > > > > in NMI") > > > > > > > > Yup, the include was there because of printk_func_t definition that > > > > was removed by the above commit. > > > > > > > > Reviewed-by: Petr Mladek > > > > > > > > > Hey Andrew, it doesn't seem like I have anything big coming through > > > > > percpu, do you mind taking this. I might have some stuff due to sh, but > > > > > I'm still working on that with them. > > > > > > > > I assume that either Andrew or Dennis will take this patch. > > > > > > I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, > > > but it seems you have a consensus with Dennis that Andrew is the best > > > maintainer to take this. So, I'll send v2 with tags and Cc to him. > > > > No problem, I am going to take it, in a hour or so. I did not want to > > make chaos when Denis asked Andrew. But it is not worth resending the patch. > > The patch is comitted in printk/linux.git, branch for-5.16-fixup. > > I am going to add it into pull request for 5.16-rc2 with another fix. > > Best Regards, > Petr Thanks Petr! In general I would take it, it just depends on other circumstances such as if I'm carrying anything or if there is any other bigger issues with other mm. Right now I'm dealing with mm as a fix for hotplug in percpu has been pulled and I'm not terribly happy about it. I appreciate being looped in and made aware of the changes. Thank you Andy and Petr. Thanks, Dennis