From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC25C433F5 for ; Mon, 15 Nov 2021 14:34:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C979761B6F for ; Mon, 15 Nov 2021 14:34:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C979761B6F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5D99A6B0078; Mon, 15 Nov 2021 09:34:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58A3D6B007D; Mon, 15 Nov 2021 09:34:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4511E6B007E; Mon, 15 Nov 2021 09:34:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 32BDC6B0078 for ; Mon, 15 Nov 2021 09:34:08 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E2CF7180B7D45 for ; Mon, 15 Nov 2021 14:34:07 +0000 (UTC) X-FDA: 78811409334.03.6D55853 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id 75CBEB00009E for ; Mon, 15 Nov 2021 14:34:07 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 2F6E321709; Mon, 15 Nov 2021 14:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1636986846; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wyaeJuZiM/tXx7GlGx3YKQgNoTfHJZZRTuvL5Q2cyHQ=; b=qdTkbTYHwKXvcIUKvhXThInRP0ugFSkn/aJ6OkcCgKEUTfM3jdFR3DO8z5bJ9UfSBSKTVc bmZ3vF5BHz/zzJf4y4ahISQpP7MDSET3PWO9hTHq1eDhr+QgNz7Ddk574FxJP8Q1Vu/Ye/ GgR0d7jlLGqx2xsBxbS8dcDffaqaO/g= Received: from suse.cz (unknown [10.100.216.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EF84DA3B85; Mon, 15 Nov 2021 14:34:05 +0000 (UTC) Date: Mon, 15 Nov 2021 15:34:04 +0100 From: Petr Mladek To: Andy Shevchenko Cc: Dennis Zhou , Andrew Morton , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Steven Rostedt Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h Message-ID: References: <20211112140749.80042-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 75CBEB00009E X-Stat-Signature: q4k1wu6gu7f6iurr8gbxc4geep11yi81 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=qdTkbTYH; spf=pass (imf24.hostedemail.com: domain of pmladek@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-HE-Tag: 1636986847-258253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2021-11-15 14:57:30, Petr Mladek wrote: > On Mon 2021-11-15 12:38:03, Andy Shevchenko wrote: > > On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote: > > > On Fri 2021-11-12 13:15:51, Dennis Zhou wrote: > > > > On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote: > > > > > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > > > in NMI") the printk.h is not needed anymore in percpu.h. > > > > > > > > > > Moreover `make headerdep` complains (an excerpt) > > > > > > > > > > In file included from linux/printk.h, > > > > > from linux/dynamic_debug.h:188 > > > > > from linux/printk.h:559 <-- here > > > > > from linux/percpu.h:9 > > > > > from linux/idr.h:17 > > > > > include/net/9p/client.h:13: warning: recursive header inclusion > > > > > > > > > > Yeah, it's not a root cause of this, but removing will help to reduce > > > > > the noise. > > > > > > > > > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk > > > > > in NMI") > > > > > > Yup, the include was there because of printk_func_t definition that > > > was removed by the above commit. > > > > > > Reviewed-by: Petr Mladek > > > > > > > Hey Andrew, it doesn't seem like I have anything big coming through > > > > percpu, do you mind taking this. I might have some stuff due to sh, but > > > > I'm still working on that with them. > > > > > > I assume that either Andrew or Dennis will take this patch. > > > > I assumed you take it, that's why I haven't Cc'ed Andrew in the first place, > > but it seems you have a consensus with Dennis that Andrew is the best > > maintainer to take this. So, I'll send v2 with tags and Cc to him. > > No problem, I am going to take it, in a hour or so. I did not want to > make chaos when Denis asked Andrew. But it is not worth resending the patch. The patch is comitted in printk/linux.git, branch for-5.16-fixup. I am going to add it into pull request for 5.16-rc2 with another fix. Best Regards, Petr