From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49C6C433F5 for ; Wed, 17 Nov 2021 05:50:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C6FC61057 for ; Wed, 17 Nov 2021 05:50:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C6FC61057 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CC8AD6B0073; Wed, 17 Nov 2021 00:50:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C50C16B0074; Wed, 17 Nov 2021 00:50:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B19A26B0078; Wed, 17 Nov 2021 00:50:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id A33BC6B0073 for ; Wed, 17 Nov 2021 00:50:40 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 62DDE8249980 for ; Wed, 17 Nov 2021 05:50:30 +0000 (UTC) X-FDA: 78817347420.02.0C8BDDD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id A1B15B000198 for ; Wed, 17 Nov 2021 05:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tgX1lKFHbGYlVIxMybKAUHxepjKR3IBDm4U5W4UN3zo=; b=nzDoS8FSD4/qhGPCItt5A1bJgG 3QyU05unbBwcOHdGh7W+8lfiKBqIHXjHH2RL1LGLKQxIxc8uJRdvrZTN+dkp0ZpQcyRkvSz+++cLk wl5PsTufUAAH6Tp+hw65/tgQJ9EsNaWehtD5UuwsOos/u24vrvy8d0kf2JoRqNjJuRtC93WLBzhtk 1fFSGfiOTi3+Ao+zQFBuwjyxUUtmiwM9CsBtFIPcrplZO8PFnljTWRm6+TySoMGvrW3g6qkiBXnNQ 12aeo7acoLwc1+9NkX69xkq14/xGVz5f4+rIu0QyWeP9GVMiAKtjjicawakNOtlm3x08j9kRnN2b6 R+CWF1lw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnDpx-003Nw2-KE; Wed, 17 Nov 2021 05:50:25 +0000 Date: Tue, 16 Nov 2021 21:50:25 -0800 From: Christoph Hellwig To: NeilBrown Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/13] MM: reclaim mustn't enter FS for swap-over-NFS Message-ID: References: <163702956672.25805.16457749992977493579.stgit@noble.brown> <163703064452.25805.16932817889703270242.stgit@noble.brown> <163709852340.13692.16362531894844686350@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163709852340.13692.16362531894844686350@noble.neil.brown.name> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A1B15B000198 X-Stat-Signature: noxw4zzxydy3a3nm9sesnm7ws78c8r1y Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=nzDoS8FS; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+f4c01cfe20b1e1ad945a+6660+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f4c01cfe20b1e1ad945a+6660+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1637128229-92795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 17, 2021 at 08:35:23AM +1100, NeilBrown wrote: > + /* We can "enter_fs" for swap-cache with only __GFP_IO normal kernel style would be the /* on a line of it's own. But except for this nitpick this looks good.