From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3702C433EF for ; Wed, 17 Nov 2021 13:18:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 910D2611AF for ; Wed, 17 Nov 2021 13:18:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 910D2611AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EC2CF6B0072; Wed, 17 Nov 2021 08:18:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E71796B0073; Wed, 17 Nov 2021 08:18:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62116B0074; Wed, 17 Nov 2021 08:18:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id C86D46B0072 for ; Wed, 17 Nov 2021 08:18:42 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8B9688249980 for ; Wed, 17 Nov 2021 13:18:32 +0000 (UTC) X-FDA: 78818476464.08.FAE0469 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id F3E947001709 for ; Wed, 17 Nov 2021 13:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EZ7LImR146Ihj6AK9fKpOunzwWf1qPHV91wm5HsdWUw=; b=UIEYg54tyCeZh8T9S/BYb68gRw /Y91kgIdNN5U5b4ZxiHLTLeEXaxTMDOSpt2jyXTAcxSsmiwQ0nXWbOK8z/y84jk2P5UNGyJ7pdr4R I3kiCGox88D9VUi99OUmBn8P1CceoDaazrSSEMIzgG8B74u9SO/psSb/4zwR5a3GsGzchQ+RAX2HB 0GSzsU5I1vtb1hnp4pW4yHCdI1fJCkq7K+vHKaxelj2vIFy7UXgnZge3WEh5yA71s8UJ1fD4L9WLY snfo/TC4j/4YcCz/jGngxkEwCtNpUQ8rWZ8TQsdDwIADnHQ3akLkhcMcbG4YyFI7Vg4u32fjDpUew TITpK6Ag==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnKpV-007cmn-Ao; Wed, 17 Nov 2021 13:18:25 +0000 Date: Wed, 17 Nov 2021 13:18:25 +0000 From: Matthew Wilcox To: NeilBrown Cc: Andrew Morton , Michal Hocko , Thierry Reding , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MM: discard __GFP_ATOMIC Message-ID: References: <163712397076.13692.4727608274002939094@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163712397076.13692.4727608274002939094@noble.neil.brown.name> X-Stat-Signature: txzdct4nu48jogyz3ucwkxztbqasietg Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UIEYg54t; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F3E947001709 X-HE-Tag: 1637155110-438264 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 17, 2021 at 03:39:30PM +1100, NeilBrown wrote: > +++ b/drivers/iommu/tegra-smmu.c > @@ -676,12 +676,12 @@ static struct page *as_get_pde_page(struct tegra_smmu_as *as, > * allocate page in a sleeping context if GFP flags permit. Hence > * spinlock needs to be unlocked and re-locked after allocation. > */ > - if (!(gfp & __GFP_ATOMIC)) > + if (gfp & __GFP_DIRECT_RECLAIM) > spin_unlock_irqrestore(&as->lock, *flags); > > page = alloc_page(gfp | __GFP_DMA | __GFP_ZERO); > > - if (!(gfp & __GFP_ATOMIC)) > + if (gfp & __GFP_DIRECT_RECLAIM) > spin_lock_irqsave(&as->lock, *flags); > > /* Surely this should be gfpflags_allow_blocking() instead of poking about in the innards of gfp flags? This patch seems like a good simplification to me. Reviewed-by: Matthew Wilcox (Oracle)