From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97646C433F5 for ; Mon, 6 Dec 2021 03:38:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345BE6B007B; Sun, 5 Dec 2021 22:38:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F6B06B007D; Sun, 5 Dec 2021 22:38:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5706B007E; Sun, 5 Dec 2021 22:38:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 1273A6B007B for ; Sun, 5 Dec 2021 22:38:11 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C54BE8954B for ; Mon, 6 Dec 2021 03:38:00 +0000 (UTC) X-FDA: 78885960720.02.5DB4019 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id C836BD035190 for ; Mon, 6 Dec 2021 03:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zc629guViPb5O8ziVPTQC0LL2CGfjHRLkDsDY1SlIy0=; b=LvdUSXXI9B02qW5VzNfefVMBP7 HXrAGs30vWpS6fcQMRQSInDShxEuqIhRkUSRVvRl9w9GBZvIYiWtbszfruGRZMIgHflrPR9qq8r2p pgM9Iat+sWrYnHFaeoVrkAUGXMsZgyar5bT3n4sOqwUZ4XQQtVaE9nzhRWemzNFtZL7AfhrTQFGHm XoJFO8xV59uc2UrzLPLUNpnSrrR6lsBhVi450sajcEWEY4W/m7iJBCZ5VccTHPplM2lZx9xvc2ZRD Fh/kdbmHGHeMuv//iOaF0Rxex+oC0lqIbM2BQ+P16UN2hy9Q1lm43hCbYNIj8TXk8VnelBupoXNsO W1e3JCFw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu4p8-002iBy-8R; Mon, 06 Dec 2021 03:37:54 +0000 Date: Mon, 6 Dec 2021 03:37:54 +0000 From: Matthew Wilcox To: Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, shakeelb@google.com, ktkhai@virtuozzo.com, shy828301@gmail.com, guro@fb.com, vbabka@suse.cz, vdavydov.dev@gmail.com, raquini@redhat.com, Rafael Aquini Subject: Re: [RFC PATCH 1/2] include/linux/gfp.h: Do not allocate pages on a offlined node Message-ID: References: <20211206033338.743270-1-npache@redhat.com> <20211206033338.743270-2-npache@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211206033338.743270-2-npache@redhat.com> X-Rspamd-Queue-Id: C836BD035190 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LvdUSXXI; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: t4wdxj9qzzq7n95ugwfyiqfi7bfc8ukn X-HE-Tag: 1638761879-15341 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 05, 2021 at 10:33:37PM -0500, Nico Pache wrote: > We shouldn't allocate pages on a unavailable node. Add a check for this > in __alloc_pages_node and return NULL to avoid issues further down the > callchain. > > Also update the VM_WARN_ON in __alloc_pages_node which could skip this > warn if the gfp_mask is not GFP_THISNODE. Why is this not also needed in __folio_alloc_node()?