From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2447C433F5 for ; Wed, 1 Dec 2021 11:35:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82AF6B0073; Wed, 1 Dec 2021 06:35:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D374D6B0074; Wed, 1 Dec 2021 06:35:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20606B0075; Wed, 1 Dec 2021 06:35:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id B39656B0073 for ; Wed, 1 Dec 2021 06:35:40 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 70F61180B260F for ; Wed, 1 Dec 2021 11:35:30 +0000 (UTC) X-FDA: 78869020020.31.CE81F18 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf08.hostedemail.com (Postfix) with ESMTP id 9900030000A8 for ; Wed, 1 Dec 2021 11:35:30 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id t9so34541268wrx.7 for ; Wed, 01 Dec 2021 03:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7oFCw3r7bT3X7Dv+eyjA/okr2FmaHILwO7XorQYmoTs=; b=BlKjYbOMUR/aTDj+Ec2chakLzgzNY5VOrahaRQVT/BVafy9OG3EI8f8Rk7Wtn/mPtJ S/ZKgHGjhmylvV+Opha093vWnbSBwnOC8zXm56O8WpqHJFkaBJN8+J/NTqlnF9596O5n IONkG7mF6uVqCaXGTmIK8FrXIv0FWYuzqfzztnjzRoGC8WfDK0VnbwiQqcYQlI7ZNj3G ozRLtxrDIeYJHR0zwiYdDMTbPIKerPqfRzEnRTu3OlzRDTrtsi5JYJryWjf/Uo6jUYZo pSHa2xcSofEVwYJ8m0Mnjf/XHDblzkSMFUZh1UzN5o7SrUXZ7mKaEtgNHEe47zPhaowZ y8Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7oFCw3r7bT3X7Dv+eyjA/okr2FmaHILwO7XorQYmoTs=; b=kZvqP7oao1AkiogG8JSUu6DbnFi/CG2OJtFktE1abk0C3/tMVwmmjZuk4GZve6IB95 bWo5MCKSae6gVjBWN4A91y33AQ1kQT1kpI8wgLSvp+uRuTXhJ/d/UV9VUeUb47CTo0ON kka9awF6LYykgc/ikd3L5kHX0r4epJGfXdScf9+n1i7c9eTePJZoPHsp5ZZtBqIr+jCo 8K9/k8tzKi4iNAYoesiKkpLbC+KzYr/jOeKVOzFFiItBfYJBWY2Ru6xBliQddeZcGs/v oKuf7QkadjNCT/hyW8hC351F1HEgyWDUsJ77zr/hF/Zy/CanAV3aK3vC7o5LoUPNsoZQ geZw== X-Gm-Message-State: AOAM532BgqIa0WfUqmCj2PvaynyhvDrdkh3RNeeEqwt7FLMPtbcQJ5N0 V0zGQDtdjnpdUMiTu7VvLE1oCw== X-Google-Smtp-Source: ABdhPJwyr4p/7w9/0D8u9fu/l1X87xRMhQAf8kDNHVmbpnIb9ZmIPngnhesriY/M7C9uy4UG3lqkzw== X-Received: by 2002:a5d:54cf:: with SMTP id x15mr6333226wrv.30.1638358528549; Wed, 01 Dec 2021 03:35:28 -0800 (PST) Received: from elver.google.com ([2a00:79e0:15:13:95ad:1401:cf07:6d1a]) by smtp.gmail.com with ESMTPSA id u15sm638839wmq.13.2021.12.01.03.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 03:35:28 -0800 (PST) Date: Wed, 1 Dec 2021 12:35:22 +0100 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Vincenzo Frascino , Catalin Marinas , Peter Collingbourne , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Will Deacon , linux-arm-kernel@lists.infradead.org, Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 29/31] kasan, arm64: allow KASAN_VMALLOC with HW_TAGS Message-ID: References: <8afdf7eb0bae77d2e94210d689d524580cf5ed9a.1638308023.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8afdf7eb0bae77d2e94210d689d524580cf5ed9a.1638308023.git.andreyknvl@google.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9900030000A8 X-Stat-Signature: 5rfbxsstzi911br5pqadeszbkyioiue3 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BlKjYbOM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1638358530-2110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 30, 2021 at 11:08PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > vmalloc tagging support for HW_TAGS KASAN is now complete. > > Allow enabling CONFIG_KASAN_VMALLOC. This actually doesn't "allow" enabling it, it unconditionally enables it and a user can't disable CONFIG_KASAN_VMALLOC. I found some background in acc3042d62cb9 why arm64 wants this. > Also adjust CONFIG_KASAN_VMALLOC description: > > - Mention HW_TAGS support. > - Remove unneeded internal details: they have no place in Kconfig > description and are already explained in the documentation. > > Signed-off-by: Andrey Konovalov > --- > arch/arm64/Kconfig | 3 +-- > lib/Kconfig.kasan | 20 ++++++++++---------- > 2 files changed, 11 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c05d7a06276f..5981e5460c51 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -205,8 +205,7 @@ config ARM64 > select IOMMU_DMA if IOMMU_SUPPORT > select IRQ_DOMAIN > select IRQ_FORCED_THREADING > - select KASAN_VMALLOC if KASAN_GENERIC > - select KASAN_VMALLOC if KASAN_SW_TAGS > + select KASAN_VMALLOC This produces the following warning when making an arm64 defconfig: | WARNING: unmet direct dependencies detected for KASAN_VMALLOC | Depends on [n]: KASAN [=n] && HAVE_ARCH_KASAN_VMALLOC [=y] | Selected by [y]: | - ARM64 [=y] | | WARNING: unmet direct dependencies detected for KASAN_VMALLOC | Depends on [n]: KASAN [=n] && HAVE_ARCH_KASAN_VMALLOC [=y] | Selected by [y]: | - ARM64 [=y] To unconditionally select KASAN_VMALLOC, it should probably be select KASAN_VMALLOC if KASAN