From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A52C433F5 for ; Sun, 5 Dec 2021 12:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E980D6B0078; Sun, 5 Dec 2021 07:00:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E46A16B007B; Sun, 5 Dec 2021 07:00:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D36876B007D; Sun, 5 Dec 2021 07:00:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id C023D6B0078 for ; Sun, 5 Dec 2021 07:00:07 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 753AE1814BA20 for ; Sun, 5 Dec 2021 11:59:57 +0000 (UTC) X-FDA: 78883596834.28.A402420 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id D71BB1046282 for ; Sun, 5 Dec 2021 11:59:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E6EE0B80E29; Sun, 5 Dec 2021 11:59:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2142C341C5; Sun, 5 Dec 2021 11:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638705593; bh=OiNkFk5G/CmqUjp/NHlUp+nNV+3LkMSULAq93llkGuE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=enWikgK+aJ7PYb+dDixnORrPlXenO6TCDd+CJi6f1QDOwd9mi/nXIVRpqAH9C/L05 J1fhLsuKXvLu9iVjc+KIiqSeHZpRL4s9rfoqd55qpZhgtH9U0b/+uezIAp1PgyUw7M 8eNyy4nqJgXJjbRvbKubvy4Gg+QE71vB+QeaXABJvKZUuHw4a5dbuWiYMhCnFb3Sh1 Is9uzWVZHzf5kgn60dMY3zXntefNx4NsyHg9p9tl+2w7kpNV0808roEEM/y5oAY5zh xvzvdBWJY1f1x2I0vF9t2ugRjio4XU/wMt43v6Fj41sOjH6/QFM8EGQK/yON2BIkDX gwihIGL8383yQ== Date: Sun, 5 Dec 2021 13:59:48 +0200 From: Leon Romanovsky To: Bixuan Cui Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, w@1wt.eu, keescook@chromium.org Subject: Re: [PATCH -next] mm: delete oversized WARN_ON() in kvmalloc() calls Message-ID: References: <1638410784-48646-1-git-send-email-cuibixuan@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1638410784-48646-1-git-send-email-cuibixuan@linux.alibaba.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D71BB1046282 X-Stat-Signature: h5s78msgmtpf693id6t78qrtyyp363g8 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=enWikgK+; spf=pass (imf13.hostedemail.com: domain of leon@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1638705596-484490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 02, 2021 at 10:06:24AM +0800, Bixuan Cui wrote: > Delete the WARN_ON() and return NULL directly for oversized parameter > in kvmalloc() calls. > Also add unlikely(). > > Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls") > Signed-off-by: Bixuan Cui How can we progress with this patch? >From this discussion, at least for RDMA, KVM and BPF, this huge size is legit and WARN_ON() can be seen as false alarm. Thanks