From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1C6C433EF for ; Fri, 10 Dec 2021 18:04:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFCD36B0072; Fri, 10 Dec 2021 13:04:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BACEB6B0073; Fri, 10 Dec 2021 13:04:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75496B0074; Fri, 10 Dec 2021 13:04:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 994266B0072 for ; Fri, 10 Dec 2021 13:04:23 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 61B99180B3DE3 for ; Fri, 10 Dec 2021 18:04:13 +0000 (UTC) X-FDA: 78902658786.26.735592D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id E28B120017 for ; Fri, 10 Dec 2021 18:04:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1313DB82706; Fri, 10 Dec 2021 18:04:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFF83C00446; Fri, 10 Dec 2021 18:04:06 +0000 (UTC) Date: Fri, 10 Dec 2021 18:04:03 +0000 From: Catalin Marinas To: andrey.konovalov@linux.dev Cc: Marco Elver , Alexander Potapenko , Vincenzo Frascino , Peter Collingbourne , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v2 32/34] arm64: select KASAN_VMALLOC for SW/HW_TAGS modes Message-ID: References: <4f56dd2bfaf945032a226f90141bb4f8e73959b7.1638825394.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f56dd2bfaf945032a226f90141bb4f8e73959b7.1638825394.git.andreyknvl@google.com> Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E28B120017 X-Stat-Signature: z67obr8g6xtpdg8nudqtq4b5fg8hzzog X-HE-Tag: 1639159452-557690 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 06, 2021 at 10:44:09PM +0100, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Generic KASAN already selects KASAN_VMALLOC to allow VMAP_STACK to be > selected unconditionally, see commit acc3042d62cb9 ("arm64: Kconfig: > select KASAN_VMALLOC if KANSAN_GENERIC is enabled"). > > The same change is needed for SW_TAGS KASAN. > > HW_TAGS KASAN does not require enabling KASAN_VMALLOC for VMAP_STACK, > they already work together as is. Still, selecting KASAN_VMALLOC still > makes sense to make vmalloc() always protected. In case any bugs in > KASAN's vmalloc() support are discovered, the command line kasan.vmalloc > flag can be used to disable vmalloc() checking. > > This patch selects KASAN_VMALLOC for all KASAN modes for arm64. > > Signed-off-by: Andrey Konovalov Acked-by: Catalin Marinas I also had a look at the rest of the patches and they look fine to me (even the init_tags comment, feel free to ignore it). I'll poke Vincenzo next week to look at the patches with his co-developed-by tag. -- Catalin