From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EB5C433EF for ; Tue, 14 Dec 2021 15:54:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766406B0071; Tue, 14 Dec 2021 10:54:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 713E16B0073; Tue, 14 Dec 2021 10:54:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DB956B0074; Tue, 14 Dec 2021 10:54:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 4E9766B0071 for ; Tue, 14 Dec 2021 10:54:22 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0BE1D8249980 for ; Tue, 14 Dec 2021 15:54:12 +0000 (UTC) X-FDA: 78916846344.08.2F85CB7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id DF5C81C0013 for ; Tue, 14 Dec 2021 15:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oJslFIdA4AG/KSWkHfzHo1CU/K0qEFS2dBN46SW5n4g=; b=wYvLy4OGOn7HEHjGPa6A+bAD+e s2Y3bNI2cK7djZ1hk1LY9aL2C45NS2CIw9TQR7ZZQgKANAHvnOPfMGwwldIxh5D8DRr/v6dcZlDiD kA8l0UShViFqFQuujYG7QN80xLbTZp1Nm+zEAY3OYxnyVAX7JXP5HKVA/kEWwD9cIgW29SmDGpBAg r7WGFuDhamogodiXPQRwQjDD8rLphsjuie+TJYiWW8bfxss7+6/lYC//HTjm3Wnj0iE11p+DhN5Wj id7/o7tciiMGv5iJ3X0X3Ry3ooLX7lY8ziGTvWJ4AQnwwoRsE4FHuZU8f02PBxHA2TJGc4X63ndp0 KhdUsF7w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxA7x-00EkhI-M7; Tue, 14 Dec 2021 15:54:05 +0000 Date: Tue, 14 Dec 2021 07:54:05 -0800 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v8 8/9] xfs: Implement ->notify_failure() for XFS Message-ID: References: <20211202084856.1285285-1-ruansy.fnst@fujitsu.com> <20211202084856.1285285-9-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202084856.1285285-9-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wYvLy4OG; spf=none (imf20.hostedemail.com: domain of BATV+86a4492529da8568e983+6687+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+86a4492529da8568e983+6687+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Queue-Id: DF5C81C0013 X-Stat-Signature: mgrpgpzn8rnr948red35pcugnd7eymyg X-Rspamd-Server: rspam04 X-HE-Tag: 1639497249-716351 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + // TODO check and try to fix metadata Please avoid //-style comments. > +static u64 > +xfs_dax_ddev_offset( > + struct xfs_mount *mp, > + struct dax_device *dax_dev, > + u64 disk_offset) > +{ > + xfs_buftarg_t *targp; > + > + if (mp->m_ddev_targp->bt_daxdev == dax_dev) > + targp = mp->m_ddev_targp; > + else if (mp->m_logdev_targp->bt_daxdev == dax_dev) > + targp = mp->m_logdev_targp; > + else > + targp = mp->m_rtdev_targp; > + > + return disk_offset - targp->bt_dax_part_off; This is only called for the data device. So I think we can simplify this and open code the logic in xfs_dax_notify_ddev_failure. > +void > +xfs_notify_failure_register( > + struct xfs_mount *mp, > + struct dax_device *dax_dev) > +{ > + if (dax_dev && !fs_dax_get_holder(dax_dev)) > + fs_dax_register_holder(dax_dev, mp, &xfs_dax_holder_operations); > +} > + > +void > +xfs_notify_failure_unregister( > + struct dax_device *dax_dev) > +{ > + if (dax_dev) > + fs_dax_unregister_holder(dax_dev); > +} Why do we need these wrappers? Also instead of the fs_dax_get_holder here, fs_dax_register_holder needs to return an error if there already is a holder.