linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	nvdimm@lists.linux.dev, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, djwong@kernel.org,
	dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org,
	jane.chu@oracle.com
Subject: Re: [PATCH v8 1/9] dax: Use percpu rwsem for dax_{read,write}_lock()
Date: Tue, 14 Dec 2021 07:40:36 -0800	[thread overview]
Message-ID: <Ybi69MCK5sP4ebwG@infradead.org> (raw)
In-Reply-To: <20211202084856.1285285-2-ruansy.fnst@fujitsu.com>

On Thu, Dec 02, 2021 at 04:48:48PM +0800, Shiyang Ruan wrote:
> In order to introduce dax holder registration, we need a write lock for
> dax.  Change the current lock to percpu_rw_semaphore and introduce a
> write lock for registration.

Why do we need to change the existing, global locking for that?

What is the impact of this to benchmarks?  Also if we stop using srcu
protection, we should be able to get rid of grace periods or RCU frees.


  reply	other threads:[~2021-12-14 15:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  8:48 [RESEND PATCH v8 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan
2021-12-02  8:48 ` [PATCH v8 1/9] dax: Use percpu rwsem for dax_{read,write}_lock() Shiyang Ruan
2021-12-14 15:40   ` Christoph Hellwig [this message]
2021-12-15  2:06     ` Shiyang Ruan
2021-12-16  7:46       ` Christoph Hellwig
2021-12-02  8:48 ` [PATCH v8 2/9] dax: Introduce holder for dax_device Shiyang Ruan
2021-12-15  3:09   ` Dan Williams
2021-12-02  8:48 ` [PATCH v8 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2021-12-02  8:48 ` [PATCH v8 4/9] pagemap,pmem: Introduce ->memory_failure() Shiyang Ruan
2021-12-02  8:48 ` [PATCH v8 5/9] fsdax: Introduce dax_lock_mapping_entry() Shiyang Ruan
2021-12-14 15:42   ` Christoph Hellwig
2021-12-02  8:48 ` [PATCH v8 6/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2021-12-14 15:47   ` Christoph Hellwig
2021-12-02  8:48 ` [PATCH v8 7/9] dax: add dax holder helper for filesystems Shiyang Ruan
2021-12-14 15:47   ` Christoph Hellwig
2021-12-15  2:21     ` Shiyang Ruan
2021-12-16  7:46       ` Christoph Hellwig
2021-12-02  8:48 ` [PATCH v8 8/9] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2021-12-14 15:54   ` Christoph Hellwig
2021-12-14 16:01   ` Darrick J. Wong
2021-12-02  8:48 ` [PATCH v8 9/9] fsdax: set a CoW flag when associate reflink mappings Shiyang Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ybi69MCK5sP4ebwG@infradead.org \
    --to=hch@infradead.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=jane.chu@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=ruansy.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).