From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85338C433F5 for ; Tue, 14 Dec 2021 15:42:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1096D6B0071; Tue, 14 Dec 2021 10:42:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B8BE6B0073; Tue, 14 Dec 2021 10:42:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE9A76B0074; Tue, 14 Dec 2021 10:42:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id DFF116B0071 for ; Tue, 14 Dec 2021 10:42:33 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A36A78249980 for ; Tue, 14 Dec 2021 15:42:23 +0000 (UTC) X-FDA: 78916816566.24.A4069BF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id BC51940006 for ; Tue, 14 Dec 2021 15:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Wjypj8Z4Rg2+/h76mxjfwvjNCwkDu0E5brw7BKK/Hgg=; b=tEcA6K5ehWXLXPQsfXCwOObarL o9UpZ+PNLeaJUmIx3vlOncBNz490UxrZQ/NmCOjVKIwb5lN4VhmSGPZAwepg/YiyAY4AnACoFxINY t8IdsbIknSUucM0SSZD6aszBSZXaJdL4CfYFmAssolfBUEYR+3X723Yu3Fh7clCmsBmi+H04ObrwW pyt1MBkpdXUfw8bIez2ZYlkMN6/S1uQsngkzIAYHWskZbmvM8UYMP3MbJ1/arbc7RmVJrqK75epfW 9LKWCKpFSx2a5XzjKbbj9paf/ciMmgU0TKzYdT4tObMCSI9uwU4uwIB6eskGmkkaWDzH4U8Bh2z9a wLYnR0bg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9wU-00EjQ3-QS; Tue, 14 Dec 2021 15:42:14 +0000 Date: Tue, 14 Dec 2021 07:42:14 -0800 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org, jane.chu@oracle.com Subject: Re: [PATCH v8 5/9] fsdax: Introduce dax_lock_mapping_entry() Message-ID: References: <20211202084856.1285285-1-ruansy.fnst@fujitsu.com> <20211202084856.1285285-6-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202084856.1285285-6-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: BC51940006 X-Stat-Signature: u7ng8s9qyjwj7k3mp9uaqidu5o1jks6m Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tEcA6K5e; spf=none (imf04.hostedemail.com: domain of BATV+86a4492529da8568e983+6687+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+86a4492529da8568e983+6687+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam10 X-HE-Tag: 1639496539-778360 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 02, 2021 at 04:48:52PM +0800, Shiyang Ruan wrote: > The current dax_lock_page() locks dax entry by obtaining mapping and > index in page. To support 1-to-N RMAP in NVDIMM, we need a new function > to lock a specific dax entry corresponding to this file's mapping,index. > And BTW, output the page corresponding to the specific dax entry for > caller use. s/BTW, //g > /* > - * dax_lock_mapping_entry - Lock the DAX entry corresponding to a page > + * dax_lock_page - Lock the DAX entry corresponding to a page > * @page: The page whose entry we want to lock > * > * Context: Process context. This should probably got into a separate trivial fix. Otherwise looks good: Reviewed-by: Christoph Hellwig