From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E6E6C433F5 for ; Thu, 16 Dec 2021 08:56:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFDA16B0074; Thu, 16 Dec 2021 03:55:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BADFC6B0075; Thu, 16 Dec 2021 03:55:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75D26B0078; Thu, 16 Dec 2021 03:55:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 99BBF6B0074 for ; Thu, 16 Dec 2021 03:55:55 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 50CAB886C7 for ; Thu, 16 Dec 2021 08:55:45 +0000 (UTC) X-FDA: 78923049450.19.8A48819 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by imf10.hostedemail.com (Postfix) with ESMTP id ADA3AC000F for ; Thu, 16 Dec 2021 08:55:40 +0000 (UTC) Received: by mail-wr1-f53.google.com with SMTP id a9so42802792wrr.8 for ; Thu, 16 Dec 2021 00:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SOuxRFXySPzshUyGC5iL0C2CvH+JBhvny1eTkHaCuAk=; b=C3+lWk3b0y78VVa5eWSCceWoMVKh8OoLiXVo7+b6aykRMYMZS84tnO1iY3ilDuL+9S kNFtEfRVtO639culhM0FpOo4Y5s9vMHKmSsjGZuezi40pU5i8mpnOQ3RS+oeaRMH3hl9 pPN24fNaNFy0a9PsTywZjzg/vJ29iwzznOpSkfNmKYcxwRecN9Ii8967W2bG+MsJYOzd zipVfIzveylYNsmoBr6s3JwYXRZnmQ2MZdQL4HlJjlJcy9Yugxhwqe9D+SjsSbm+OJ0B hqYQy30NATx1d4buHLlzpvm/LnePURXPW/Ml0FrbTWnDlmXYjVLLhwVt0JIVC5anZtg1 swTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SOuxRFXySPzshUyGC5iL0C2CvH+JBhvny1eTkHaCuAk=; b=X9H3HnpnF0ZUPTgwS1EHacR+vQwor0vRVDo33BB2gNP1RUmkNm8Tnm5aoRtWCjiWu5 LNadtyWKrcEPX/MsqzB9NSUvegQgoTQgPSwqpFxKOLgYFTdpb8+L3ggTv7UMNmsNdPc0 qilQjmCuyVarKGoG4UiDKd8y8kx343ZnP+GAj+/NSog6D4qkILrnBmkHlmKDm3ml/uqT ENmMegy5usRgk8nVKqdfmVUIg4qY6jb5cvntkMWq6rAlm/stRFkxbWWThkZymq7L9nTb DfEM+UQ6kyCiPuR7TD2slRlqJHqz+ZlD2Qg1XLoYxZJFDsnOP4Giz4dYTecW/wnontIw omhw== X-Gm-Message-State: AOAM530Sp6auEcQkGiIKOxQ7cjzSZES285698KUbOWv2SQdxGSP2W32i PsZVo+dgizwWO9cetkQXUJE= X-Google-Smtp-Source: ABdhPJwbtAMNBx3u2dBIsPqwFJsMFEOrlFqylkByzKob5f0kf3vZdqodg/kqdagKi6U3S/JWjAH3Vg== X-Received: by 2002:adf:a18b:: with SMTP id u11mr7678332wru.397.1639644943821; Thu, 16 Dec 2021 00:55:43 -0800 (PST) Received: from orome ([193.209.96.43]) by smtp.gmail.com with ESMTPSA id w15sm4090586wrk.77.2021.12.16.00.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 00:55:42 -0800 (PST) Date: Thu, 16 Dec 2021 09:55:39 +0100 From: Thierry Reding To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, iommu@lists.linux-foundation.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, willy@infradead.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, linux-mm@kvack.org, Mikko Perttunen , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 03/11] drm/tegra: vic: Fix DMA API misuse Message-ID: References: <6b86f6e530b504a5eee864af10e2ae1570d7b645.1639157090.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xaI96K7vWbm32g6g" Content-Disposition: inline In-Reply-To: <6b86f6e530b504a5eee864af10e2ae1570d7b645.1639157090.git.robin.murphy@arm.com> User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10) X-Rspamd-Queue-Id: ADA3AC000F X-Stat-Signature: nipcycc1wrkus4zgbb7osh87fq4a5fgd Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=C3+lWk3b; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of thierry.reding@gmail.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=thierry.reding@gmail.com X-Rspamd-Server: rspam02 X-HE-Tag: 1639644940-425497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xaI96K7vWbm32g6g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 10, 2021 at 05:54:44PM +0000, Robin Murphy wrote: > Upon failure, dma_alloc_coherent() returns NULL. If that does happen, > passing some uninitialised stack contents to dma_mapping_error() - which > belongs to a different API in the first place - has precious little > chance of detecting it. >=20 > Also include the correct header, because the fragile transitive > inclusion currently providing it is going to break soon. >=20 > Fixes: 20e7dce255e9 ("drm/tegra: Remove memory allocation from Falcon lib= rary") > CC: Thierry Reding > CC: Mikko Perttunen > CC: dri-devel@lists.freedesktop.org > Signed-off-by: Robin Murphy >=20 > --- >=20 > It also doesn't appear to handle failure of the tegra_drm_alloc() path > either, but that's a loose thread I have no desire to pull on... ;) >=20 > v2: Resend as part of the series, originally posted separately here: >=20 > https://lore.kernel.org/dri-devel/2703882439344010e33bf21ecd63cf9e5e6dc00= d.1637781007.git.robin.murphy@arm.com/ >=20 > drivers/gpu/drm/tegra/vic.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Applied, thanks. I've also fixed up the missing failure handling for tegra_drm_alloc(), which was actually quite trivial to do. Thierry --xaI96K7vWbm32g6g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG6/wsACgkQ3SOs138+ s6G5Ng//YzfjTiVGwWVICqHpvgQHCcZ8oVaca2ULy6V9X+H0OOwBsrnOOsQRNQPN bhUymR2MvtF7CGkWXSLcLBInR683ccLJefYom3K7kd/Lf1bptAbYsIIR6mEU/iHF dgk52WgEANXqXpjIkny9hIQdmgjL4ilBS9vwZnBniFIfNTAER2fEy3CsfvoQnkC6 0ZoB9zaj+a+PBUy2oGB0K51wzoYWglCG5sbD94eeztUwdZtnWcFz8FpYWLVZQgvb OH7mgLECdjDiu6ZJ+/h57xcO2gR0NhEPOlq5fhyWd6M2OMcqmwE4xEmH14zyq1RS maeLK89xm8X7BCEneOai8B70OH2nzW7dHYMFT33WWJOVzvfX9jBzTn5aMxif8T1x NYoJew1GJDCvc0hE1SQyWLqfomvVE9Ctod8pgR18us9XMn0jhQZ9+9frVE661g7C 0ATJ+ekU7msdPeQGG+gIgOoBI1nxVlhMyaeiEA5ZUI7jaa118EAS5o7RFHGW55yu YTmw+ZiJ1Oqtm+sJIco6G4z30Su+rsAo99K0lALgJ0op2uBibF49yGyoDvfM/k62 7fgmTjnj2tA/V4isGVdH8/JjF8gvferm8YCBh2PZlArczHEUTOh1hIoNwxGOGIG7 y02bpMz2KLrRaOdf+ut96A/t1b+aUMiwgnH1cOyt1cy7SuBVvjU= =+ED4 -----END PGP SIGNATURE----- --xaI96K7vWbm32g6g--