From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C441FC433F5 for ; Thu, 16 Dec 2021 07:46:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBE3B6B0074; Thu, 16 Dec 2021 02:46:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E46A06B0075; Thu, 16 Dec 2021 02:46:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE8136B0078; Thu, 16 Dec 2021 02:46:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay033.a.hostedemail.com [64.99.140.33]) by kanga.kvack.org (Postfix) with ESMTP id BF67C6B0074 for ; Thu, 16 Dec 2021 02:46:45 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8ECB120A1D for ; Thu, 16 Dec 2021 07:46:35 +0000 (UTC) X-FDA: 78922875150.03.CCE9F07 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id 1D9C240017 for ; Thu, 16 Dec 2021 07:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=vcE5xITae30eveBT3POA+xHhwo2Q6buP3s15knpDWAk=; b=1NvmtU84iD7rhEWYoHr3V3n88g OAJv7aoNOrpLdpLwN8Oz1upyeMGK/mS64MImUsI38e4fdymihSix5zkisblNC5odr4juDFRln35AQ EzhZztmT5R5QcInMeeDB5xf3XRyYjdi+efc29SWqeqZkXVbEW39ooh60jz/vKIzSsU7nlldOK0p0/ ftgA8nvk6MWFFruogKAYWMmVVquHEwUgBJbKRT2wpBOblDRSsQeMhPsnKQf/JGTwwnlBlf/lAOCSJ /3iBEI/gRQZS6DLZRwJBFGHWhHKWsgvIMqgVl6T6Y2onPefoluFKObDyY0Q6PSGBnCX4xAq40mGvI DFEH4FAw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxlTD-0040QN-VT; Thu, 16 Dec 2021 07:46:31 +0000 Date: Wed, 15 Dec 2021 23:46:31 -0800 From: Christoph Hellwig To: Shiyang Ruan Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, dan.j.williams@intel.com, david@fromorbit.com, jane.chu@oracle.com Subject: Re: [PATCH v8 7/9] dax: add dax holder helper for filesystems Message-ID: References: <20211202084856.1285285-1-ruansy.fnst@fujitsu.com> <20211202084856.1285285-8-ruansy.fnst@fujitsu.com> <2c0d1b44-5b7f-f4d0-a7ca-0cf692a0cdd4@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2c0d1b44-5b7f-f4d0-a7ca-0cf692a0cdd4@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1D9C240017 X-Stat-Signature: ofndeg44whdtay7xakmmbh97ctptgw4i Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1NvmtU84; spf=none (imf04.hostedemail.com: domain of BATV+371907e433806b178f45+6689+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+371907e433806b178f45+6689+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1639640794-211721 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 15, 2021 at 10:21:00AM +0800, Shiyang Ruan wrote: > > > 在 2021/12/14 23:47, Christoph Hellwig 写道: > > On Thu, Dec 02, 2021 at 04:48:54PM +0800, Shiyang Ruan wrote: > > > Add these helper functions, and export them for filesystem use. > > > > What is the point of adding these wrappers vs just calling the > > underlying functions? > > I added them so that they can be called in a friendly way, even if > CONFIG_DAX is off. Otherwise, we need #if IS_ENABLED(CONFIG_DAX) to wrap > them where they are called. No need for wrappers, you can stub out the underlying functions as well.