From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B69C433F5 for ; Thu, 16 Dec 2021 08:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A662B6B0074; Thu, 16 Dec 2021 03:03:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A154F6B0075; Thu, 16 Dec 2021 03:03:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DD5B6B0078; Thu, 16 Dec 2021 03:03:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 801566B0074 for ; Thu, 16 Dec 2021 03:03:00 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4974C8249980 for ; Thu, 16 Dec 2021 08:02:50 +0000 (UTC) X-FDA: 78922916100.19.1A087A7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id CA7EFC0019 for ; Thu, 16 Dec 2021 08:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zeVgdZekYVoCGoOE4CcwJQVXY4jKJylsxXTQbazh+cE=; b=an6HXGxmAx1lVJmu2Y3Kix0OAZ HNpsqt7EP9RrYvtl97awiKnppOtpZjZNNuZ0N60kHHqe9PxYfe05lpd/JCekTOmpvzp23mHtnYxzx pLD48v92RM40acXVUJgzWKXxzb7WoCCkWt/JsZSQozXyrtvxo8rBRPL8VffUtbJepW6RTxhIcXPPZ nX9g4s+q93ka0UqgxtMgqGtz3wj+3s2jV5NrLkkmv+Cxc18M5J0jJqlhcKEklUUgE+Ux35VNoxFL4 oyQrQwavtZ76NGW+9/DYjS1Fvjaa37pYDB3DIC+I6F2HK32CJ+GF3aXV+GByJTTufHGonBSRKaEh1 ok4CSTyw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxlit-0042S8-0Y; Thu, 16 Dec 2021 08:02:43 +0000 Date: Thu, 16 Dec 2021 00:02:42 -0800 From: Christoph Hellwig To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH v2 05/11] iommu/iova: Squash flush_cb abstraction Message-ID: References: <6326303c396e28fd3b9ed89d82673dfcf159b8c6.1639157090.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6326303c396e28fd3b9ed89d82673dfcf159b8c6.1639157090.git.robin.murphy@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=an6HXGxm; spf=none (imf28.hostedemail.com: domain of BATV+371907e433806b178f45+6689+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+371907e433806b178f45+6689+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CA7EFC0019 X-Stat-Signature: jb9ij6pdc6i5eoa44616t7pj73h7r9y9 X-HE-Tag: 1639641769-973162 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > @@ -147,7 +142,7 @@ struct iova *reserve_iova(struct iova_domain *iovad, unsigned long pfn_lo, > unsigned long pfn_hi); > void init_iova_domain(struct iova_domain *iovad, unsigned long granule, > unsigned long start_pfn); > -int init_iova_flush_queue(struct iova_domain *iovad, iova_flush_cb flush_cb); > +int init_iova_flush_queue(struct iova_domain *iovad, struct iommu_domain *fq_domain); Overly long line here. Otherwise looks good: Reviewed-by: Christoph Hellwig