From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9149DC433FE for ; Tue, 21 Dec 2021 08:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12EA56B0078; Tue, 21 Dec 2021 03:36:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF496B007B; Tue, 21 Dec 2021 03:36:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36896B007D; Tue, 21 Dec 2021 03:36:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id E06BC6B0078 for ; Tue, 21 Dec 2021 03:36:34 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 978DE181AC9C6 for ; Tue, 21 Dec 2021 08:36:34 +0000 (UTC) X-FDA: 78941145108.09.D350588 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 2AE8518001D for ; Tue, 21 Dec 2021 08:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bev5UwUDySNtcXZ7IbUg3yOmocPFGSISGcvag7Sq58Q=; b=HAPbiOL2hqJaqg/4Wb6uKUEuOb Htg78H8fB44s1S4lq7nQQbrNItf7oqgP7CnnX8VCmQ7nmATKnAY4mfiYeshBLINj8dUY+gGOKksg8 y7/eeXHqTE/fywSrKbKvxH/tN61lfWCznBMkbvDAvjio/Y5xToFGn0Y3UaoHTstQ2tE9WHzVW3f4B RdfSm8zmmybWDTcniynbcCziNP2Gs15CLRnkF/heHehNo97n9wnxEVl4wxbBKwMmdWG5XcunEtQ+V zx2bk5wp8zWlG8IMpYRO3l69PsX74PB9iPcriFgZ6YsIqxAE9cSpHCih17A3cigW6xBT1gCq5U28H TuVITm9Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzadH-005xM6-Uk; Tue, 21 Dec 2021 08:36:27 +0000 Date: Tue, 21 Dec 2021 00:36:27 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/18] MM: create new mm/swap.h header file. Message-ID: References: <163969801519.20885.3977673503103544412.stgit@noble.brown> <163969850279.20885.7172996032577523902.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163969850279.20885.7172996032577523902.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 2AE8518001D X-Stat-Signature: of71cjxnxffjjzwmdjzw48h6e6spuqrc Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=HAPbiOL2; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+1bb9050bde7847c37d79+6694+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1bb9050bde7847c37d79+6694+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1640075793-545281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 17, 2021 at 10:48:22AM +1100, NeilBrown wrote: > Many functions declared in include/linux/swap.h are only used within mm/ > > Create a new "mm/swap.h" and move some of these declarations there. > Remove the redundant 'extern' from the function declarations. Good idea! Looks good modulo the extra includes that the buildbot asks for: Reviewed-by: Christoph Hellwig