From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7C5C433FE for ; Tue, 21 Dec 2021 08:44:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B16D6B007B; Tue, 21 Dec 2021 03:44:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 960D36B007D; Tue, 21 Dec 2021 03:44:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 850446B007E; Tue, 21 Dec 2021 03:44:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 77BB96B007B for ; Tue, 21 Dec 2021 03:44:41 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3C32D180A8482 for ; Tue, 21 Dec 2021 08:44:41 +0000 (UTC) X-FDA: 78941165562.20.57F8CF7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 0158D4002E for ; Tue, 21 Dec 2021 08:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nPiQf/MI+bwqfpcWS154xJ3aaU/G74L5bGAeKIKv96Q=; b=Qdnk4yIhbeEGJ9r6rR1zk/TxJh SOlUOwTdLYDRrQJpF+5v2r6ImMjcS8OZGR3NA3dFaIakL0CoaflRO97iBuN2T2j0ROo3rMh8VTvq/ f2t5onLlGMdGYTTIAT8xBTplYP+mmnRTiKsiB6inFWmkc9Ujm40e8oALDZhcO/LdgvOlk1qT+McBB oP0NXKUoULs7vAFNQ2UDupLhKqPI8MkBo32rHivR/ncCZwQ446qQtwV0GsaSunkHAy79rO2UvrgtO 3AQJuz5pIcBNqOy2MPEv78nVzoc1qcEhhfYCr0yRG0U6WNeoUrw5uANYBuGg3nCGtSdhlBQrhhTXm ej5Iu/fw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzal9-005xx1-IT; Tue, 21 Dec 2021 08:44:35 +0000 Date: Tue, 21 Dec 2021 00:44:35 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/18] MM: submit multipage reads for SWP_FS_OPS swap-space Message-ID: References: <163969801519.20885.3977673503103544412.stgit@noble.brown> <163969850296.20885.16043920355602134308.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163969850296.20885.16043920355602134308.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0158D4002E X-Stat-Signature: okciri1e7iisfp3hz9p19aswms5jaebt Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Qdnk4yIh; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+1bb9050bde7847c37d79+6694+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1bb9050bde7847c37d79+6694+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1640076273-499316 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 17, 2021 at 10:48:22AM +1100, NeilBrown wrote: > Some caller currently call blk_finish_plug() *before* the final call to > swap_readpage(), so the last page cannot be included. This patch moves > blk_finish_plug() to after the last call, and calls swap_read_unplug() > there too. Can you move this fix into a separate prep patch, preferably with a Fixes tag so that it gets picked up for backports? Otherwise this looks sensible to me.