From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B650C433FE for ; Tue, 21 Dec 2021 08:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD7E76B007D; Tue, 21 Dec 2021 03:41:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B60056B007E; Tue, 21 Dec 2021 03:41:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A01D36B0080; Tue, 21 Dec 2021 03:41:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 913A16B007D for ; Tue, 21 Dec 2021 03:41:35 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 586B282FD7 for ; Tue, 21 Dec 2021 08:41:35 +0000 (UTC) X-FDA: 78941157750.25.65F1126 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 259FF20019 for ; Tue, 21 Dec 2021 08:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1SfuWtyBT/lCOeUjHpOa8oNjQ7IYPylpMxyFG1nXMrQ=; b=UO/t1vtyfCs/03PyiOpu8/Jt28 8yISYgBUk47c8mXqrG4qYbjL5hAseZWZypz86F42rcXgxhiIGSKAoUsXnHc2wlMNQnYSlPhXvylG4 eb1x+8vcDP+1jqnqFCa40Tv/7KpmvLEyW+o0miLF3XhMjt8PbB8vC5gVYHPjghjf6aS8MpFwfArCM I1omI8tzS497dL4Oo+VWRXnxYysvRAx/8W2B9lmiC6JJyn9B21TN0hyJGLuV4KDCwqCPRai+06t3B tsxNDzngO0OEwEZNXvNddGlo63h5U76bPHODnDJF/rv3d7QF/LHhj3G/zVq4spBK/TicWybqsazm8 4f3lfJyQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzai9-005xhw-Km; Tue, 21 Dec 2021 08:41:29 +0000 Date: Tue, 21 Dec 2021 00:41:29 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/18] MM: perform async writes to SWP_FS_OPS swap-space Message-ID: References: <163969801519.20885.3977673503103544412.stgit@noble.brown> <163969850292.20885.16191050558510542930.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163969850292.20885.16191050558510542930.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 259FF20019 X-Stat-Signature: 1yz85fcytrbpdih5sekukygp84kgm81d Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="UO/t1vty"; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+1bb9050bde7847c37d79+6694+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+1bb9050bde7847c37d79+6694+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1640076094-933688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 17, 2021 at 10:48:22AM +1100, NeilBrown wrote: > Writes to SWP_FS_OPS swapspace is currently synchronous. To make it > async we need to allocate the kiocb struct which may block, but won't > block as long as waiting for the write to complete would block. Against a little helper for the SWP_FS_OPS case of __swap_writepage would be nice. But otherwise this looks good to me.