Re: [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS

Andrey Konovalov
2021-12-30T19:11:41Z

On Tue, Dec 21, 2021 at 1:05 PM Marco Elver <elver@google.com> wrote:
>
> On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote:
> [...]
> > #ifdef CONFIG_KASAN_HW_TAGS
> > #define __def_gfpflag_names_kasan \
> > - , {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"}
> > + , {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"} \
> > + , {(unsigned long)__GFP_SKIP_KASAN_UNPOISON, \
> > + "__GFP_SKIP_KASAN_UNPOISON"}
> > #else
> > #define __def_gfpflag_names_kasan
> > #endif
>
> Adhering to 80 cols here makes the above less readable. If you do a v5,
> my suggestion is:
>
> diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h
> index f18eeb5fdde2..f9f0ae3a4b6b 100644
> --- a/include/trace/events/mmflags.h
> +++ b/include/trace/events/mmflags.h
> @@ -51,11 +51,10 @@
> {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"} \
>
> #ifdef CONFIG_KASAN_HW_TAGS
> -#define __def_gfpflag_names_kasan \
> - , {(unsigned long)__GFP_SKIP_ZERO, "__GFP_SKIP_ZERO"} \
> - , {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"} \
> - , {(unsigned long)__GFP_SKIP_KASAN_UNPOISON, \
> - "__GFP_SKIP_KASAN_UNPOISON"}
> +#define __def_gfpflag_names_kasan , \
> + {(unsigned long)__GFP_SKIP_ZERO, "__GFP_SKIP_ZERO"}, \
> + {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"}, \
> + {(unsigned long)__GFP_SKIP_KASAN_UNPOISON, "__GFP_SKIP_KASAN_UNPOISON"}
> #else
> #define __def_gfpflag_names_kasan
> #endif

Will do in v5, thanks!