From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E9AC433EF for ; Thu, 23 Dec 2021 06:57:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 598766B0072; Thu, 23 Dec 2021 01:57:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 548056B0073; Thu, 23 Dec 2021 01:57:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 436536B0074; Thu, 23 Dec 2021 01:57:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 356BE6B0072 for ; Thu, 23 Dec 2021 01:57:30 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E39C18249980 for ; Thu, 23 Dec 2021 06:57:29 +0000 (UTC) X-FDA: 78948153018.07.718886B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id EAB3440009 for ; Thu, 23 Dec 2021 06:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WPo3rUtHdmaW1U0F0Pgab9Jp9oFcpx/AjX/YBliZmQY=; b=iWxhfs7vGbZhl/9PmwIJAilm8F XzFirwn6J7N4I7cWYsyqP7TOQljwCRsNg+2C4oMkyyUI/ubAC1vAZjY/kIUQlmiAZJzUekm6Bo4SN s3gfQKO/9gL0+JQ+tz6Hg0iWC21jVIoJD2cdDMeI+V3/pFYZ6UN0tOaZBJ0hRaFMyoKpUR+Sp3vgv 3dyw0sHWOK6+p7sMCJFJ3B9aRsjPKRUMzFisn68kyfu5fcVPPVVEi4QUXHQJhnlIK+YB62jvoQhnj 494qgTtGy8xca95UB7HqyUpo6/7BHIsCtamyjgx8HK7gn3ytlWtfmmHfJQxk2u7VXKSNk1XdUs7+q kHbEthJQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0I2a-00BwyF-BV; Thu, 23 Dec 2021 06:57:28 +0000 Date: Wed, 22 Dec 2021 22:57:28 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/48] iov_iter: Convert iter_xarray to use folios Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-8-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: EAB3440009 X-Stat-Signature: 3cwh19syf7ac5urz74wd6dmioytjp3ke Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=iWxhfs7v; spf=none (imf11.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam10 X-HE-Tag: 1640242646-240002 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + size_t offset = offset_in_folio(folio, start + __off); \ > + if (xas_retry(&xas, folio)) \ > continue; \ > + if (WARN_ON(xa_is_value(folio))) \ > break; \ > + if (WARN_ON(folio_test_hugetlb(folio))) \ > break; \ > + while (offset < folio_size(folio)) { \ Nit: I'd be tempted to use a for loop on offset here. Otherwise looks good: Reviewed-by: Christoph Hellwig