From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D305C433F5 for ; Thu, 23 Dec 2021 06:54:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BB216B0072; Thu, 23 Dec 2021 01:54:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 969766B0073; Thu, 23 Dec 2021 01:54:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 858526B0074; Thu, 23 Dec 2021 01:54:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 766436B0072 for ; Thu, 23 Dec 2021 01:54:29 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2D9B48A3F4 for ; Thu, 23 Dec 2021 06:54:29 +0000 (UTC) X-FDA: 78948145458.21.56939B4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id C2E5140037 for ; Thu, 23 Dec 2021 06:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UqYj4/ZoXrbTAGwPYQVwmUR0ull7fD69GaAxZ4CoMYc=; b=fc1kVFHQ7a8AbbqfnqzrCl2dgD Lq3axW8CfTKyAWJQv9/aUCDq6NnZVCRExK0Da5xojPcFibm1NZSzFb1jZvCJbBOLuKc6Npt9uMuGA jmsFfvwpNc0ZjqOBsMsOc9QWegcJ+6Eng8LwEAFIW6USQT8CPL+B1dNEI7PaRk17VR0zdminf+kSJ DOOkF8YNJC8dWiZYN4gIXxtqVb8RIM9uxR55/A3RN6tAghzKQW5ubaYs53eOmwc3u0xCWrVsrO4Da O4s1TH9TSVy9oDi3RzYFn47Mnb4GWXUiwt/dt9PZS/A92YfazKOMfZZFRh5qPI5ZANbKfRt+UEAJb Km4MEwlg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0Hzf-00BwsO-1d; Thu, 23 Dec 2021 06:54:27 +0000 Date: Wed, 22 Dec 2021 22:54:27 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/48] pagevec: Add folio_batch Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-6-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: C2E5140037 X-Stat-Signature: bdn4dxtscp7gfct91i7tq5r6inuicdsd Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=fc1kVFHQ; dmarc=none; spf=none (imf01.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1640242460-473642 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 08, 2021 at 04:22:13AM +0000, Matthew Wilcox (Oracle) wrote: > +static inline void folio_batch_release(struct folio_batch *fbatch) > +{ > + pagevec_release((struct pagevec *)fbatch); > +} > + > +static inline void folio_batch_remove_exceptionals(struct folio_batch *fbatch) > +{ > + pagevec_remove_exceptionals((struct pagevec *)fbatch); > +} I think these casts need documentation, both here and at the struct folio_batch and struct pagevec definitions. Alternatively I wonder if a union in stuct pagevec so that it can store folios or pages might be the better option.