From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AED2C433EF for ; Thu, 23 Dec 2021 06:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9AF36B0073; Thu, 23 Dec 2021 01:55:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E4AB16B0074; Thu, 23 Dec 2021 01:55:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3A616B0075; Thu, 23 Dec 2021 01:55:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id C5DBF6B0073 for ; Thu, 23 Dec 2021 01:55:22 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8734D876E7 for ; Thu, 23 Dec 2021 06:55:22 +0000 (UTC) X-FDA: 78948147684.02.4665B4E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 08416140022 for ; Thu, 23 Dec 2021 06:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kF4sNyn9ejq9BtQYgVVIDSuUx7Z2F5fcvy9sdc+/3x8=; b=AVQp79haHjGsW4kCnihJQXQaYa 5PGGlGwhKiMPzy41/ftnhAo4LRo38jrDmmhgYC5bJBqTQXPr07FOWTt+Lbpym2XAcK1lShjCeTGjw f2f7mPSY6ZbjH8v12KsFwhso8o/1MEV3P8hxG6exZ2XJc75XYoafT1PHhRRS5jbt9ScARu2VHffve aYFkasTYFhcL0BUxnowiv9WnHMFxriszbhVTXI6TZ1QTeNh0SU8b5l/JU9ZVJkvvhfuCucURxONkA Zkv7F8KfhwQg0w1C9yvn2W/uoDFgjdzF/PXDzvgLaUS8mUuax981TkJfoaX8MA/LETiJ5ZURr9AqQ oFTmxOQg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0I0W-00BwuU-Rc; Thu, 23 Dec 2021 06:55:20 +0000 Date: Wed, 22 Dec 2021 22:55:20 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/48] iov_iter: Add copy_folio_to_iter() Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-7-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 08416140022 X-Stat-Signature: s5u71k576mj6kuymc4ox37mfq3o8hs6c Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=AVQp79ha; spf=none (imf09.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1640242516-763518 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 08, 2021 at 04:22:14AM +0000, Matthew Wilcox (Oracle) wrote: > +static inline size_t copy_folio_to_iter(struct folio *folio, size_t offset, > + size_t bytes, struct iov_iter *i) > +{ > + return copy_page_to_iter((struct page *)folio, offset, bytes, i); > +} I think we had this 2 or three series ago, but these open coded casts are a bad idea. I think we need a proper and well documented helper for them.