From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD325C433EF for ; Thu, 23 Dec 2021 07:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BBAC6B0072; Thu, 23 Dec 2021 02:00:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56AE36B0073; Thu, 23 Dec 2021 02:00:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45A5E6B0074; Thu, 23 Dec 2021 02:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 32B026B0072 for ; Thu, 23 Dec 2021 02:00:43 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E557B89082 for ; Thu, 23 Dec 2021 07:00:42 +0000 (UTC) X-FDA: 78948161124.03.29204FA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 80AB480035 for ; Thu, 23 Dec 2021 07:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cI2eNvkPdNCsZZUycWNgBhNphIpO0K2pcfM73hmVJAA=; b=sE7cxoouchhe9E7yZ9ppcbkA7m Har6oGYJLCkb0K2GW14alvFUP7u7uUuvvk2GTPTksUj6d2p1q/erdj9NQQ27zM+rRdnnG27wBhfPv vtLImBICsux1QNC+lNgYdka233uudk9mVVYNhaRzqcdb8afRsIiT6VV0iIjeZ7fpH4ngZSCS8UmJU yn46nMAGyznYKGWcCGJ5oypDjVv+SV96rdv7yN0KmbhaQkFEp6hOaJ6pRUyRXO/Xuib32XKYnBNc2 IR4AxSuMJBabdbaJnH38ICGGQr51yQt6JZNWEwbgZRw9FulRoZaqjfEaBY0fypP9kKqb/c68wQYt9 znVNrrhg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0I5g-00Bx5z-8Z; Thu, 23 Dec 2021 07:00:40 +0000 Date: Wed, 22 Dec 2021 23:00:40 -0800 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/48] filemap: Add folio_put_wait_locked() Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: tjakmwga4ffq86k4xbs79hs6pa3drhju X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 80AB480035 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=sE7cxoou; spf=none (imf30.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1640242842-851666 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -int put_and_wait_on_page_locked(struct page *page, int state); > +int folio_put_wait_locked(struct folio *folio, int state); This could actually move to mm/internal.h. Otherwise looks good: Reviewed-by: Christoph Hellwig