From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE252C433EF for ; Thu, 23 Dec 2021 07:16:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7314C6B0072; Thu, 23 Dec 2021 02:16:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E2136B0073; Thu, 23 Dec 2021 02:16:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D0276B0074; Thu, 23 Dec 2021 02:16:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 49D1B6B0072 for ; Thu, 23 Dec 2021 02:16:11 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 017A9181AC9C6 for ; Thu, 23 Dec 2021 07:16:11 +0000 (UTC) X-FDA: 78948200142.20.D1DB10B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id F21EE4000B for ; Thu, 23 Dec 2021 07:16:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3MhPbOkAZgtg0QEx7CyigJkf3+S+Yd4tDm8nvdtt2tg=; b=3f97ko0x6KxU2rvyv1nSgCEVJJ yz2R8cwnjG8q1NeeI9j7TzJvGI/WVbtqvuqmzJoGzRvpAXQpXdAhuquIMGn1TRQdXxTBd3plp3/sH kdqZk8uTVxiuHgFRYJigCwlkol/Itn7mOgQl3Zy5wiDVcSKc1fcwKUUv8cEkqvyVam+pYJ8WYqlDV Ypr0XMCvUpYiz2uajGzofu0GLYuCNmS2ItlzsUq/8RJo9WIHyKsUQTMtahySqVqDLnwT7B1XKxE8V cHbsSRX5lyWNx0lhBNvxVMltBEEu2EV8EPkalbAoyO/xdTdnDJIUZzUNR84mHLgosvDP4yUXFA/GV S+MIZ8Uw==; Received: from 089144208226.atnat0017.highway.a1.net ([89.144.208.226] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0IKe-00BxiW-8l; Thu, 23 Dec 2021 07:16:09 +0000 Date: Thu, 23 Dec 2021 08:16:03 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 17/48] filemap: Convert find_get_pages_contig to folios Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-18-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3f97ko0x; spf=none (imf27.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F21EE4000B X-Stat-Signature: 41phxr477qiui87okuijgqrkornf57ym X-HE-Tag: 1640243769-40446 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 08, 2021 at 04:22:25AM +0000, Matthew Wilcox (Oracle) wrote: > None of the callers of find_get_pages_contig() want tail pages. They all > use order-0 pages today, but if they were converted, they'd want folios. > So just remove the call to find_subpage() instead of replacing it with > folio_page(). Looks good, Reviewed-by: Christoph Hellwig