From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6240EC433EF for ; Thu, 23 Dec 2021 07:37:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BADCE6B0072; Thu, 23 Dec 2021 02:37:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5CEC6B0073; Thu, 23 Dec 2021 02:37:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4C036B0074; Thu, 23 Dec 2021 02:37:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 988116B0072 for ; Thu, 23 Dec 2021 02:37:36 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5CF8A89553 for ; Thu, 23 Dec 2021 07:37:36 +0000 (UTC) X-FDA: 78948254112.06.6AD83E2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 3D65D140037 for ; Thu, 23 Dec 2021 07:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vRuGGVR17Eaw5L4S4jIlNw83rAhhD+mXf4QcgiPDK30=; b=eDhR/Un3pICEbzbmHT2rcsWmg7 wsNr4QBTO9i9nlJDA3hBTW4xkBbJm7UvcmHIcRG2OfB9uBXPnIHw/AdkyHQqzx9PNKMhzlJXwD8kg IDvTcYogcr8NJelAPJxsjc4Tg4nL+lQt32+KMFLJrFJylCGotsX5zGKtq+L0TAfyo0hqCKW/d7GQx ygJqJWoplg9ayIbTMku2hVWQ04Bqb69bXLnYHZqogb7w29lpkwigEfoIFB3Pjrk/IwnHWE9Q7FUX/ oZmE3PJdc0locolaQSbFtKtztsn4QHHu/iv3wRaMZ0fBF4adBH0d1u1YL/6dv1Oqm8qRrvyCfzUy6 PFts45kw==; Received: from 089144214178.atnat0023.highway.a1.net ([89.144.214.178] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0IfL-00ByhM-2U; Thu, 23 Dec 2021 07:37:33 +0000 Date: Thu, 23 Dec 2021 08:36:45 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 33/48] mm: Add unmap_mapping_folio() Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-34-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211208042256.1923824-34-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3D65D140037 X-Stat-Signature: 3tsi7azfjm1emgimybnuoicunquypbua Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="eDhR/Un3"; spf=none (imf09.hostedemail.com: domain of BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+873f21062ce73a87fae7+6696+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1640245050-856643 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 08, 2021 at 04:22:41AM +0000, Matthew Wilcox (Oracle) wrote: > Convert both callers of unmap_mapping_page() to call unmap_mapping_folio() > instead. Also move zap_details from linux/mm.h to mm/internal.h In fact it could even move to mm/memory.c as no one needs it outside of that file. __oom_reap_task_mm always passes a NULL zap_details argument to unmap_page_range. Otherwise looks good, Reviewed-by: Christoph Hellwig