From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1964C433EF for ; Fri, 24 Dec 2021 06:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ECC76B0075; Fri, 24 Dec 2021 01:14:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89B176B0078; Fri, 24 Dec 2021 01:14:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78AA76B007B; Fri, 24 Dec 2021 01:14:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 6B5BD6B0075 for ; Fri, 24 Dec 2021 01:14:26 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 28438181AC9C6 for ; Fri, 24 Dec 2021 06:14:26 +0000 (UTC) X-FDA: 78951673332.21.2D0FC74 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id E5621140026 for ; Fri, 24 Dec 2021 06:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WUkLTn/WpLXgwb+kcxpzWPSSTcTX45kVNzTV9/wI4Ao=; b=LSupGGxGeGDAKTQkM7bYQdWNvl YNShVJrf+3j7/jShaDkJRCKPrA194/KVrenqyuPHscwBnr+CW8Xu9PzTggVNYfA5+rlX7UUdyecZW 0B3IjBqInlkXhaGTgyzlPs2GBFCRdMgYIeGb0tUDH23DRIi2yYZRQSI61NdzijzkPImrz20gPlnue YZsHzqg3HLmKFg1oZnizwc4XabL11kKgjdBSu+uLk3rOBQ5nVMXww99sUgJpJOnt6YIVuAqTcT/D3 oZKCfP0djMxqy0sMcmPunrsO4hmq8OW4eLqlLN+ljndne73aiwCSjqemGdJCkCe//dIKgX4Inx2Cj PvXlF9Lw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0dqP-00Dmjx-40; Fri, 24 Dec 2021 06:14:21 +0000 Date: Thu, 23 Dec 2021 22:14:21 -0800 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 07/48] iov_iter: Convert iter_xarray to use folios Message-ID: References: <20211208042256.1923824-1-willy@infradead.org> <20211208042256.1923824-8-willy@infradead.org> <800800.1640273061@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <800800.1640273061@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: E5621140026 X-Stat-Signature: rk4oxfoy69x7zaxrwf6x967kqe9txe15 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LSupGGxG; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+afcec93cc8ffef6ccdbc+6697+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+afcec93cc8ffef6ccdbc+6697+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam11 X-HE-Tag: 1640326457-507226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 23, 2021 at 03:24:21PM +0000, David Howells wrote: > > > + while (offset < folio_size(folio)) { \ > > > > Nit: I'd be tempted to use a for loop on offset here. > > A while-loop makes more sense here. The adjustment you need for offset > (ie. len) is overwritten after offset is altered at the end of the loop: > > > + offset += len; \ > > + len = PAGE_SIZE; \ > > } \ > > So you'd have to move both of these into the for-incrementor expression, in > addition to moving in the initialiser expression, making the thing less > readable. Ok.