From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
John Hubbard <jhubbard@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] mm/migration: Add trace events for THP migrations
Date: Fri, 24 Dec 2021 14:48:30 +0000 [thread overview]
Message-ID: <YcXdvnLC5SyiSZTc@casper.infradead.org> (raw)
In-Reply-To: <1640328398-20698-1-git-send-email-anshuman.khandual@arm.com>
On Fri, Dec 24, 2021 at 12:16:38PM +0530, Anshuman Khandual wrote:
> This adds two trace events for PMD based THP migration without split. These
> events closely follow the implementation details like setting and removing
> of PMD migration entries, which are essential operations for THP migration.
Why are you printing the address of a struct page? What useful
information does this supply? Same question for the struct mm.
And the pmdp, for that matter.
You haven't said _why_ you want these tracepoints. So it's impossible
to suggest what you _should_ be doing, because what you _are_ doing
is obviously wrong.
> + TP_printk("mm=%p, address=%lx, pmdp=%p, page=%p pmdval=%lx",
> + __entry->mm,
> + __entry->address,
> + __entry->pmdp,
> + __entry->page,
> + __entry->pmdval)
> +);
next prev parent reply other threads:[~2021-12-24 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 6:46 [RFC] mm/migration: Add trace events for THP migrations Anshuman Khandual
2021-12-24 14:48 ` Matthew Wilcox [this message]
2022-01-03 3:54 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcXdvnLC5SyiSZTc@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rostedt@goodmis.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).