From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2502AC433F5 for ; Fri, 24 Dec 2021 14:48:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 289A46B0071; Fri, 24 Dec 2021 09:48:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 239C66B0072; Fri, 24 Dec 2021 09:48:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 128AD6B0073; Fri, 24 Dec 2021 09:48:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 00D5D6B0071 for ; Fri, 24 Dec 2021 09:48:38 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 954338249980 for ; Fri, 24 Dec 2021 14:48:38 +0000 (UTC) X-FDA: 78952969116.26.046A1E1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id E7A43140022 for ; Fri, 24 Dec 2021 14:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h6TSfmTuL7ftgtvLoRTjxtkYWFFbSSFkXY0fzO/SUDY=; b=m2TYgIu4yzYXx0XYdpBiRwbNdt P4mOpo74aj/PPHaO1zHmqggesyBIVDuMVzHS7swl6OJIXgvhcATBwM0MmXjRNqIatHfqXSu54jivG 0yLIDXg9lRzqsVv1YAFdomGOrb402lCbWPRhQ+IboMWkR25LacY5FOAHrmFV9Tnt0PPc1Coh+E/yA BtHg8IBNlbKO05KweDFxYCUWUv248FEvJJsNZLa4I11x6SCVt5yb/Fmw+zQWqMCXnJv9uXhWEmR8p XanKG7dICCGO/XtareJpHGUv/V/XhKwKmBD62XBQY6UQvOiFsSM0SIURxMlFB0XHBegEnrMcX15Ra TfZwyiNw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0lry-005ARv-Nn; Fri, 24 Dec 2021 14:48:30 +0000 Date: Fri, 24 Dec 2021 14:48:30 +0000 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, Steven Rostedt , Ingo Molnar , Andrew Morton , Zi Yan , Naoya Horiguchi , John Hubbard , linux-kernel@vger.kernel.org Subject: Re: [RFC] mm/migration: Add trace events for THP migrations Message-ID: References: <1640328398-20698-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1640328398-20698-1-git-send-email-anshuman.khandual@arm.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E7A43140022 X-Stat-Signature: 7ziwhceyp7r7xbg8prnewbg6jshbqk1d Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m2TYgIu4; dmarc=none; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1640357311-810809 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 24, 2021 at 12:16:38PM +0530, Anshuman Khandual wrote: > This adds two trace events for PMD based THP migration without split. These > events closely follow the implementation details like setting and removing > of PMD migration entries, which are essential operations for THP migration. Why are you printing the address of a struct page? What useful information does this supply? Same question for the struct mm. And the pmdp, for that matter. You haven't said _why_ you want these tracepoints. So it's impossible to suggest what you _should_ be doing, because what you _are_ doing is obviously wrong. > + TP_printk("mm=%p, address=%lx, pmdp=%p, page=%p pmdval=%lx", > + __entry->mm, > + __entry->address, > + __entry->pmdp, > + __entry->page, > + __entry->pmdval) > +);